Movatterモバイル変換

Skip to content

coder/coderPublic

NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

fix(cli): properly handle build log streaming during`coder ping`#15600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

ethanndickson merged 1 commit intomainfromethan/ping-cleanup

Nov 20, 2024

Merged

fix(cli): properly handle build log streaming during`coder ping`#15600

ethanndickson merged 1 commit intomainfromethan/ping-cleanup

Nov 20, 2024

Conversation

ethanndickson

Copy link

Member

ethanndickson commentedNov 20, 2024•
edited
Loading

Closes#15584.

TheCollecting Diagnostics spinner now starts after the workspace build logs (if any) have finished streaming.
Removes network interfaces with negative MTUs fromhealthsdk diagnostics.
Improves the wording on diagnostics for MTUs below the 'safe' value to indicate that direct connections may be degraded, or rendered unusable (i.e. if every packet is dropped).

@ethanndickson

fix(cli): properly handle build log streaming duringcoder ping

231263f

@ethanndickson

Graphite App

Copy link

MemberAuthor

ethanndickson commentedNov 20, 2024

fix(cli): properly handle build log streaming duringcoder ping #15600 👈(View in Graphite)
main

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@github-actions

github-actionsbot assignedethanndickson

@ethanndickson

ethanndickson marked this pull request as ready for review

November 20, 2024 03:27

@ethanndickson

ethanndickson requested a review fromdeansheather

November 20, 2024 03:28

deansheather

deansheather approved these changes

View reviewed changes

@ethanndickson

ethanndickson merged commit6e7f65b intomain

35 checks passed

@ethanndickson

ethanndickson deleted the ethan/ping-cleanup branch

November 20, 2024 04:50

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

2 participants

@ethanndickson

@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp