Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add deployment config option to append custom csp directives#15596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 6 commits intomainfromstevenmasley/addition_csp_directives
Nov 21, 2024

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedNov 19, 2024
edited
Loading

Allows adding custom static CSP directives to Coder. Niche use case but makes this easier then creating a reverse proxy that has to replace the header. We want to preserve our directives, so having an append option is preferred to a "replace" option via a reverse proxy.

Closes#15118

Some notes

We do not validate the directives set. Browsers have different sets of support, so we accept any string values.

Screenshot from 2024-11-19 11-22-08

Example configuring. The format matches the header format.

coder server ... --additional-csp-policy="script-src https://example.com google.com"# can also do it likecoder server ... --additional-csp-policy="script-src https://example.com" --additional-csp-policy="script-src https://google.com"

Allows adding custom static CSP directives to Coder. Niche use casebut makes this easier then creating a reverse proxy that has toreplace the header. We want to preserve our directives.
@EmyrkEmyrk changed the titlechore: deployment config option to append custom csp directiveschore: add deployment config option to append custom csp directivesNov 19, 2024
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@EmyrkEmyrk merged commit5b7fa78 intomainNov 21, 2024
30 of 31 checks passed
@EmyrkEmyrk deleted the stevenmasley/addition_csp_directives branchNovember 21, 2024 17:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Embedding Coder Instance - CSP Frame Ancestor Issue

3 participants

@Emyrk@dannykopping@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp