Dec 2, 2024 · Nov 18, 2024 · Nov 18, 2024 · Nov 19, 2024 · Nov 19, 2024 · Nov 19, 2024
diff --git a/cli/testdata/coder_list_--output_json.golden b/cli/testdata/coder_list_--output_json.golden
    },
    "automatic_updates": "never",
    "allow_renames": false,
    "favorite": false
    "favorite": false,
    "next_start_at": "[timestamp]"
  }
 ]
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/coderd/autobuild/lifecycle_executor.go b/coderd/autobuild/lifecycle_executor.go
 // NOTE: If a workspace build is created with a given TTL and then the user either
 //       changes or unsets the TTL, the deadline for the workspace build will not
 //       have changed. This behavior is as expected per #2229.
 workspaces, err := e.db.GetWorkspacesEligibleForTransition(e.ctx,t)
 workspaces, err := e.db.GetWorkspacesEligibleForTransition(e.ctx,currentTick)
 if err != nil {
 e.log.Error(e.ctx, "get workspaces for autostart or autostop", slog.Error(err))
 return stats
 return xerrors.Errorf("get template scheduling options: %w", err)
 }

 // If next start at is not valid we need to re-compute it
 if !ws.NextStartAt.Valid && ws.AutostartSchedule.Valid {
 next, err := schedule.NextAllowedAutostart(currentTick, ws.AutostartSchedule.String, templateSchedule)
 if err == nil {
 nextStartAt := sql.NullTime{Valid: true, Time: dbtime.Time(next.UTC())}
 if err = tx.UpdateWorkspaceNextStartAt(e.ctx, database.UpdateWorkspaceNextStartAtParams{
 ID:          wsID,
 NextStartAt: nextStartAt,
 }); err != nil {
 return xerrors.Errorf("update workspace next start at: %w", err)
 }

 // Save re-fetching the workspace
 ws.NextStartAt = nextStartAt
 }
 }

 tmpl, err = tx.GetTemplateByID(e.ctx, ws.TemplateID)
 if err != nil {
 return xerrors.Errorf("get template by ID: %w", err)
 return false
 }

 nextTransition,allowed := schedule.NextAutostart(build.CreatedAt, ws.AutostartSchedule.String, templateSchedule)
 if!allowed {
 nextTransition,err := schedule.NextAllowedAutostart(build.CreatedAt, ws.AutostartSchedule.String, templateSchedule)
 iferr != nil {
 return false
 }

diff --git a/coderd/autobuild/lifecycle_executor_test.go b/coderd/autobuild/lifecycle_executor_test.go
 IncludeProvisionerDaemon: true,
 NotificationsEnqueuer:    &notifyEnq,
 TemplateScheduleStore: schedule.MockTemplateScheduleStore{
 SetFn: func(ctx context.Context, db database.Store, template database.Template, options schedule.TemplateScheduleOptions) (database.Template, error) {
 template.TimeTilDormant = int64(options.TimeTilDormant)
 return schedule.NewAGPLTemplateScheduleStore().Set(ctx, db, template, options)
 },
 GetFn: func(_ context.Context, _ database.Store, _ uuid.UUID) (schedule.TemplateScheduleOptions, error) {
 return schedule.TemplateScheduleOptions{
 UserAutostartEnabled: false,
 )

 coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID)
 template := coderdtest.CreateTemplate(t, client, admin.OrganizationID, version.ID)
 template := coderdtest.CreateTemplate(t, client, admin.OrganizationID, version.ID, func(ctr *codersdk.CreateTemplateRequest) {
 ctr.TimeTilDormantMillis = ptr.Ref(timeTilDormant.Milliseconds())
 })
 userClient, _ := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID)
 workspace := coderdtest.CreateWorkspace(t, userClient, template.ID)
 coderdtest.AwaitWorkspaceBuildJobCompleted(t, userClient, workspace.LatestBuild.ID)
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
 return q.db.BatchUpdateWorkspaceLastUsedAt(ctx, arg)
 }

 func (q *querier) BatchUpdateWorkspaceNextStartAt(ctx context.Context, arg database.BatchUpdateWorkspaceNextStartAtParams) error {
 if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceWorkspace.All()); err != nil {
 return err
 }
 return q.db.BatchUpdateWorkspaceNextStartAt(ctx, arg)
 }

 func (q *querier) BulkMarkNotificationMessagesFailed(ctx context.Context, arg database.BulkMarkNotificationMessagesFailedParams) (int64, error) {
 if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceNotificationMessage); err != nil {
 return 0, err
 return q.db.GetAuthorizedWorkspacesAndAgentsByOwnerID(ctx, ownerID, prep)
 }

 func (q *querier) GetWorkspacesByTemplateID(ctx context.Context, templateID uuid.UUID) ([]database.WorkspaceTable, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
 return nil, err
 }
 return q.db.GetWorkspacesByTemplateID(ctx, templateID)
 }

 func (q *querier) GetWorkspacesEligibleForTransition(ctx context.Context, now time.Time) ([]database.GetWorkspacesEligibleForTransitionRow, error) {
 return q.db.GetWorkspacesEligibleForTransition(ctx, now)
 }
 return update(q.log, q.auth, fetch, q.db.UpdateWorkspaceLastUsedAt)(ctx, arg)
 }

 func (q *querier) UpdateWorkspaceNextStartAt(ctx context.Context, arg database.UpdateWorkspaceNextStartAtParams) error {
 fetch := func(ctx context.Context, arg database.UpdateWorkspaceNextStartAtParams) (database.Workspace, error) {
 return q.db.GetWorkspaceByID(ctx, arg.ID)
 }
 return update(q.log, q.auth, fetch, q.db.UpdateWorkspaceNextStartAt)(ctx, arg)
 }

 func (q *querier) UpdateWorkspaceProxy(ctx context.Context, arg database.UpdateWorkspaceProxyParams) (database.WorkspaceProxy, error) {
 fetch := func(ctx context.Context, arg database.UpdateWorkspaceProxyParams) (database.WorkspaceProxy, error) {
 return q.db.GetWorkspaceProxyByID(ctx, arg.ID)
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
 ID: ws.ID,
 }).Asserts(ws, policy.ActionUpdate).Returns()
 }))
 s.Run("UpdateWorkspaceNextStartAt", s.Subtest(func(db database.Store, check *expects) {
 ws := dbgen.Workspace(s.T(), db, database.WorkspaceTable{})
 check.Args(database.UpdateWorkspaceNextStartAtParams{
 ID:          ws.ID,
 NextStartAt: sql.NullTime{Valid: true, Time: dbtime.Now()},
 }).Asserts(ws, policy.ActionUpdate)
 }))
 s.Run("BatchUpdateWorkspaceNextStartAt", s.Subtest(func(db database.Store, check *expects) {
 check.Args(database.BatchUpdateWorkspaceNextStartAtParams{
 IDs:          []uuid.UUID{uuid.New()},
 NextStartAts: []time.Time{dbtime.Now()},
 }).Asserts(rbac.ResourceWorkspace.All(), policy.ActionUpdate)
 }))
 s.Run("BatchUpdateWorkspaceLastUsedAt", s.Subtest(func(db database.Store, check *expects) {
 ws1 := dbgen.Workspace(s.T(), db, database.WorkspaceTable{})
 ws2 := dbgen.Workspace(s.T(), db, database.WorkspaceTable{})
 s.Run("GetTemplateAverageBuildTime", s.Subtest(func(db database.Store, check *expects) {
 check.Args(database.GetTemplateAverageBuildTimeParams{}).Asserts(rbac.ResourceSystem, policy.ActionRead)
 }))
 s.Run("GetWorkspacesByTemplateID", s.Subtest(func(db database.Store, check *expects) {
 check.Args(uuid.Nil).Asserts(rbac.ResourceSystem, policy.ActionRead)
 }))
 s.Run("GetWorkspacesEligibleForTransition", s.Subtest(func(db database.Store, check *expects) {
 check.Args(time.Time{}).Asserts()
 }))
diff --git a/coderd/database/dbgen/dbgen.go b/coderd/database/dbgen/dbgen.go
 AutostartSchedule: orig.AutostartSchedule,
 Ttl:               orig.Ttl,
 AutomaticUpdates:  takeFirst(orig.AutomaticUpdates, database.AutomaticUpdatesNever),
 NextStartAt:       orig.NextStartAt,
 })
 require.NoError(t, err, "insert workspace")
 return workspace
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
 DeletingAt:        w.DeletingAt,
 AutomaticUpdates:  w.AutomaticUpdates,
 Favorite:          w.Favorite,
 NextStartAt:       w.NextStartAt,

 OwnerAvatarUrl: extended.OwnerAvatarUrl,
 OwnerUsername:  extended.OwnerUsername,
 return nil
 }

 func (q *FakeQuerier) BatchUpdateWorkspaceNextStartAt(_ context.Context, arg database.BatchUpdateWorkspaceNextStartAtParams) error {
 err := validateDatabaseType(arg)
 if err != nil {
 return err
 }

 q.mutex.Lock()
 defer q.mutex.Unlock()

 for i, workspace := range q.workspaces {
 for j, workspaceID := range arg.IDs {
 if workspace.ID != workspaceID {
 continue
 }

 nextStartAt := arg.NextStartAts[j]
 if nextStartAt.IsZero() {
 q.workspaces[i].NextStartAt = sql.NullTime{}
 } else {
 q.workspaces[i].NextStartAt = sql.NullTime{Valid: true, Time: nextStartAt}
 }

 break
 }
 }

 return nil
 }

 func (*FakeQuerier) BulkMarkNotificationMessagesFailed(_ context.Context, arg database.BulkMarkNotificationMessagesFailedParams) (int64, error) {
 err := validateDatabaseType(arg)
 if err != nil {
 return q.GetAuthorizedWorkspacesAndAgentsByOwnerID(ctx, ownerID, nil)
 }

 func (q *FakeQuerier) GetWorkspacesByTemplateID(_ context.Context, templateID uuid.UUID) ([]database.WorkspaceTable, error) {
 q.mutex.RLock()
 defer q.mutex.RUnlock()

 workspaces := []database.WorkspaceTable{}
 for _, workspace := range q.workspaces {
 if workspace.TemplateID == templateID {
 workspaces = append(workspaces, workspace)
 }
 }

 return workspaces, nil
 }

 func (q *FakeQuerier) GetWorkspacesEligibleForTransition(ctx context.Context, now time.Time) ([]database.GetWorkspacesEligibleForTransitionRow, error) {
 q.mutex.RLock()
 defer q.mutex.RUnlock()
 if user.Status == database.UserStatusActive &&
 job.JobStatus != database.ProvisionerJobStatusFailed &&
 build.Transition == database.WorkspaceTransitionStop &&
 workspace.AutostartSchedule.Valid {
 workspace.AutostartSchedule.Valid &&
 // We do not know if workspace with a zero next start is eligible
 // for autostart, so we accept this false-positive. This can occur
 // when a coder version is upgraded and next_start_at has yet to
 // be set.
 (workspace.NextStartAt.Time.IsZero() ||
 !now.Before(workspace.NextStartAt.Time)) {
 workspaces = append(workspaces, database.GetWorkspacesEligibleForTransitionRow{
 ID:   workspace.ID,
 Name: workspace.Name,

 if !workspace.DormantAt.Valid &&
 template.TimeTilDormant > 0 &&
 now.Sub(workspace.LastUsedAt) > time.Duration(template.TimeTilDormant) {
 now.Sub(workspace.LastUsedAt) >= time.Duration(template.TimeTilDormant) {
 workspaces = append(workspaces, database.GetWorkspacesEligibleForTransitionRow{
 ID:   workspace.ID,
 Name: workspace.Name,
 Ttl:               arg.Ttl,
 LastUsedAt:        arg.LastUsedAt,
 AutomaticUpdates:  arg.AutomaticUpdates,
 NextStartAt:       arg.NextStartAt,
 }
 q.workspaces = append(q.workspaces, workspace)
 return workspace, nil
 continue
 }
 workspace.AutostartSchedule = arg.AutostartSchedule
 workspace.NextStartAt = arg.NextStartAt
 q.workspaces[index] = workspace
 return nil
 }
 return sql.ErrNoRows
 }

 func (q *FakeQuerier) UpdateWorkspaceNextStartAt(_ context.Context, arg database.UpdateWorkspaceNextStartAtParams) error {
 err := validateDatabaseType(arg)
 if err != nil {
 return err
 }

 q.mutex.Lock()
 defer q.mutex.Unlock()

 for index, workspace := range q.workspaces {
 if workspace.ID != arg.ID {
 continue
 }

 workspace.NextStartAt = arg.NextStartAt
 q.workspaces[index] = workspace

 return nil
 }

 return sql.ErrNoRows
 }

 func (q *FakeQuerier) UpdateWorkspaceProxy(_ context.Context, arg database.UpdateWorkspaceProxyParams) (database.WorkspaceProxy, error) {
 q.mutex.Lock()
 defer q.mutex.Unlock()
diff --git a/coderd/database/dbmetrics/querymetrics.go b/coderd/database/dbmetrics/querymetrics.go
Original file line number	Diff line number	Diff line change
Expand Up		@@ -65,6 +65,7 @@
		},
		"automatic_updates": "never",
		"allow_renames": false,
		"favorite": false
		"favorite": false,
		"next_start_at": "[timestamp]"
		}
		]
Original file line number	Diff line number	Diff line change
Expand Up		@@ -142,7 +142,7 @@ func (e *Executor) runOnce(t time.Time) Stats {
		// NOTE: If a workspace build is created with a given TTL and then the user either
		// changes or unsets the TTL, the deadline for the workspace build will not
		// have changed. This behavior is as expected per #2229.
		workspaces, err := e.db.GetWorkspacesEligibleForTransition(e.ctx,t)
		workspaces, err := e.db.GetWorkspacesEligibleForTransition(e.ctx,currentTick)
DanielleMaywood marked this conversation as resolved. Show resolvedHide resolved
		if err != nil {
		e.log.Error(e.ctx, "get workspaces for autostart or autostop", slog.Error(err))
		return stats
Expand DownExpand Up		@@ -205,6 +205,23 @@ func (e *Executor) runOnce(t time.Time) Stats {
		return xerrors.Errorf("get template scheduling options: %w", err)
		}

		// If next start at is not valid we need to re-compute it
		if !ws.NextStartAt.Valid && ws.AutostartSchedule.Valid {
		next, err := schedule.NextAllowedAutostart(currentTick, ws.AutostartSchedule.String, templateSchedule)
		if err == nil {
		nextStartAt := sql.NullTime{Valid: true, Time: dbtime.Time(next.UTC())}
		if err = tx.UpdateWorkspaceNextStartAt(e.ctx, database.UpdateWorkspaceNextStartAtParams{
		ID: wsID,
		NextStartAt: nextStartAt,
		}); err != nil {
		return xerrors.Errorf("update workspace next start at: %w", err)
		}

		// Save re-fetching the workspace
		ws.NextStartAt = nextStartAt
		}
		}

		tmpl, err = tx.GetTemplateByID(e.ctx, ws.TemplateID)
		if err != nil {
		return xerrors.Errorf("get template by ID: %w", err)
Expand DownExpand Up		@@ -463,8 +480,8 @@ func isEligibleForAutostart(user database.User, ws database.Workspace, build dat
		return false
		}

		nextTransition,allowed := schedule.NextAutostart(build.CreatedAt, ws.AutostartSchedule.String, templateSchedule)
		if!allowed {
		nextTransition,err := schedule.NextAllowedAutostart(build.CreatedAt, ws.AutostartSchedule.String, templateSchedule)
		iferr != nil {
		return false
		}

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1083,6 +1083,10 @@ func TestNotifications(t *testing.T) {
		IncludeProvisionerDaemon: true,
		NotificationsEnqueuer: &notifyEnq,
		TemplateScheduleStore: schedule.MockTemplateScheduleStore{
		SetFn: func(ctx context.Context, db database.Store, template database.Template, options schedule.TemplateScheduleOptions) (database.Template, error) {
		template.TimeTilDormant = int64(options.TimeTilDormant)
		return schedule.NewAGPLTemplateScheduleStore().Set(ctx, db, template, options)
		},
		GetFn: func(_ context.Context, _ database.Store, _ uuid.UUID) (schedule.TemplateScheduleOptions, error) {
		return schedule.TemplateScheduleOptions{
		UserAutostartEnabled: false,
Expand All		@@ -1099,7 +1103,9 @@ func TestNotifications(t *testing.T) {
		)

		coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID)
		template := coderdtest.CreateTemplate(t, client, admin.OrganizationID, version.ID)
		template := coderdtest.CreateTemplate(t, client, admin.OrganizationID, version.ID, func(ctr *codersdk.CreateTemplateRequest) {
		ctr.TimeTilDormantMillis = ptr.Ref(timeTilDormant.Milliseconds())
		})
		userClient, _ := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID)
		workspace := coderdtest.CreateWorkspace(t, userClient, template.ID)
		coderdtest.AwaitWorkspaceBuildJobCompleted(t, userClient, workspace.LatestBuild.ID)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1030,6 +1030,13 @@ func (q *querier) BatchUpdateWorkspaceLastUsedAt(ctx context.Context, arg databa
		return q.db.BatchUpdateWorkspaceLastUsedAt(ctx, arg)
		}

		func (q *querier) BatchUpdateWorkspaceNextStartAt(ctx context.Context, arg database.BatchUpdateWorkspaceNextStartAtParams) error {
		if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceWorkspace.All()); err != nil {
		return err
		}
		return q.db.BatchUpdateWorkspaceNextStartAt(ctx, arg)
		}

		func (q *querier) BulkMarkNotificationMessagesFailed(ctx context.Context, arg database.BulkMarkNotificationMessagesFailedParams) (int64, error) {
		if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceNotificationMessage); err != nil {
		return 0, err
Expand DownExpand Up		@@ -2817,6 +2824,13 @@ func (q *querier) GetWorkspacesAndAgentsByOwnerID(ctx context.Context, ownerID u
		return q.db.GetAuthorizedWorkspacesAndAgentsByOwnerID(ctx, ownerID, prep)
		}

		func (q *querier) GetWorkspacesByTemplateID(ctx context.Context, templateID uuid.UUID) ([]database.WorkspaceTable, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
		return nil, err
		}
		return q.db.GetWorkspacesByTemplateID(ctx, templateID)
		}

		func (q *querier) GetWorkspacesEligibleForTransition(ctx context.Context, now time.Time) ([]database.GetWorkspacesEligibleForTransitionRow, error) {
		return q.db.GetWorkspacesEligibleForTransition(ctx, now)
		}
Expand DownExpand Up		@@ -4062,6 +4076,13 @@ func (q *querier) UpdateWorkspaceLastUsedAt(ctx context.Context, arg database.Up
		return update(q.log, q.auth, fetch, q.db.UpdateWorkspaceLastUsedAt)(ctx, arg)
		}

		func (q *querier) UpdateWorkspaceNextStartAt(ctx context.Context, arg database.UpdateWorkspaceNextStartAtParams) error {
		fetch := func(ctx context.Context, arg database.UpdateWorkspaceNextStartAtParams) (database.Workspace, error) {
		return q.db.GetWorkspaceByID(ctx, arg.ID)
		}
		return update(q.log, q.auth, fetch, q.db.UpdateWorkspaceNextStartAt)(ctx, arg)
		}

		func (q *querier) UpdateWorkspaceProxy(ctx context.Context, arg database.UpdateWorkspaceProxyParams) (database.WorkspaceProxy, error) {
		fetch := func(ctx context.Context, arg database.UpdateWorkspaceProxyParams) (database.WorkspaceProxy, error) {
		return q.db.GetWorkspaceProxyByID(ctx, arg.ID)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1908,6 +1908,19 @@ func (s *MethodTestSuite) TestWorkspace() {
		ID: ws.ID,
		}).Asserts(ws, policy.ActionUpdate).Returns()
		}))
		s.Run("UpdateWorkspaceNextStartAt", s.Subtest(func(db database.Store, check *expects) {
		ws := dbgen.Workspace(s.T(), db, database.WorkspaceTable{})
		check.Args(database.UpdateWorkspaceNextStartAtParams{
		ID: ws.ID,
		NextStartAt: sql.NullTime{Valid: true, Time: dbtime.Now()},
		}).Asserts(ws, policy.ActionUpdate)
		}))
		s.Run("BatchUpdateWorkspaceNextStartAt", s.Subtest(func(db database.Store, check *expects) {
		check.Args(database.BatchUpdateWorkspaceNextStartAtParams{
		IDs: []uuid.UUID{uuid.New()},
		NextStartAts: []time.Time{dbtime.Now()},
		}).Asserts(rbac.ResourceWorkspace.All(), policy.ActionUpdate)
		}))
		s.Run("BatchUpdateWorkspaceLastUsedAt", s.Subtest(func(db database.Store, check *expects) {
		ws1 := dbgen.Workspace(s.T(), db, database.WorkspaceTable{})
		ws2 := dbgen.Workspace(s.T(), db, database.WorkspaceTable{})
Expand DownExpand Up		@@ -2784,6 +2797,9 @@ func (s *MethodTestSuite) TestSystemFunctions() {
		s.Run("GetTemplateAverageBuildTime", s.Subtest(func(db database.Store, check *expects) {
		check.Args(database.GetTemplateAverageBuildTimeParams{}).Asserts(rbac.ResourceSystem, policy.ActionRead)
		}))
		s.Run("GetWorkspacesByTemplateID", s.Subtest(func(db database.Store, check *expects) {
		check.Args(uuid.Nil).Asserts(rbac.ResourceSystem, policy.ActionRead)
		}))
		s.Run("GetWorkspacesEligibleForTransition", s.Subtest(func(db database.Store, check *expects) {
		check.Args(time.Time{}).Asserts()
		}))
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -260,6 +260,7 @@ func Workspace(t testing.TB, db database.Store, orig database.WorkspaceTable) da
		AutostartSchedule: orig.AutostartSchedule,
		Ttl: orig.Ttl,
		AutomaticUpdates: takeFirst(orig.AutomaticUpdates, database.AutomaticUpdatesNever),
		NextStartAt: orig.NextStartAt,
		})
		require.NoError(t, err, "insert workspace")
		return workspace
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -475,6 +475,7 @@ func (q *FakeQuerier) convertToWorkspaceRowsNoLock(ctx context.Context, workspac
		DeletingAt: w.DeletingAt,
		AutomaticUpdates: w.AutomaticUpdates,
		Favorite: w.Favorite,
		NextStartAt: w.NextStartAt,

		OwnerAvatarUrl: extended.OwnerAvatarUrl,
		OwnerUsername: extended.OwnerUsername,
Expand DownExpand Up		@@ -1431,6 +1432,35 @@ func (q *FakeQuerier) BatchUpdateWorkspaceLastUsedAt(_ context.Context, arg data
		return nil
		}

		func (q *FakeQuerier) BatchUpdateWorkspaceNextStartAt(_ context.Context, arg database.BatchUpdateWorkspaceNextStartAtParams) error {
		err := validateDatabaseType(arg)
		if err != nil {
		return err
		}

		q.mutex.Lock()
		defer q.mutex.Unlock()

		for i, workspace := range q.workspaces {
		for j, workspaceID := range arg.IDs {
		if workspace.ID != workspaceID {
		continue
		}

		nextStartAt := arg.NextStartAts[j]
		if nextStartAt.IsZero() {
		q.workspaces[i].NextStartAt = sql.NullTime{}
		} else {
		q.workspaces[i].NextStartAt = sql.NullTime{Valid: true, Time: nextStartAt}
		}

		break
		}
		}

		return nil
		}

		func (*FakeQuerier) BulkMarkNotificationMessagesFailed(_ context.Context, arg database.BulkMarkNotificationMessagesFailedParams) (int64, error) {
		err := validateDatabaseType(arg)
		if err != nil {
Expand DownExpand Up		@@ -6908,6 +6938,20 @@ func (q *FakeQuerier) GetWorkspacesAndAgentsByOwnerID(ctx context.Context, owner
		return q.GetAuthorizedWorkspacesAndAgentsByOwnerID(ctx, ownerID, nil)
		}

		func (q *FakeQuerier) GetWorkspacesByTemplateID(_ context.Context, templateID uuid.UUID) ([]database.WorkspaceTable, error) {
		q.mutex.RLock()
		defer q.mutex.RUnlock()

		workspaces := []database.WorkspaceTable{}
		for _, workspace := range q.workspaces {
		if workspace.TemplateID == templateID {
		workspaces = append(workspaces, workspace)
		}
		}

		return workspaces, nil
		}

		func (q *FakeQuerier) GetWorkspacesEligibleForTransition(ctx context.Context, now time.Time) ([]database.GetWorkspacesEligibleForTransitionRow, error) {
		q.mutex.RLock()
		defer q.mutex.RUnlock()
Expand DownExpand Up		@@ -6952,7 +6996,13 @@ func (q *FakeQuerier) GetWorkspacesEligibleForTransition(ctx context.Context, no
		if user.Status == database.UserStatusActive &&
		job.JobStatus != database.ProvisionerJobStatusFailed &&
		build.Transition == database.WorkspaceTransitionStop &&
		workspace.AutostartSchedule.Valid {
		workspace.AutostartSchedule.Valid &&
		// We do not know if workspace with a zero next start is eligible
		// for autostart, so we accept this false-positive. This can occur
		// when a coder version is upgraded and next_start_at has yet to
		// be set.
Copy link Member mafredriNov 28, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. We have a new known case, reset by db trigger. Should we implement the trigger in memory db as well? (I know it's probably going away soon, but still, might cause flakes?) Copy link ContributorAuthor DanielleMaywoodNov 28, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I don'tthink it'd cause flakes, but instead cause dbmem tests to fail when postgres tests do not. Happy to add it though Copy link ContributorAuthor DanielleMaywoodNov 28, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. On second thought, I've checked`dbmem.go` for how we emulate triggers and I'm not sure there is a good way to do it. Copy link Member EmyrkDec 2, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. There is no good way to do it, just ad hoc code in various functions 😢 Copy link ContributorAuthor DanielleMaywoodDec 2, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Ah that's unfortunate. I think attempting to emulate this trigger isn't worth it then. If someone writes a test that is dependent on the trigger (which they ideally shouldn't) then they'll have to disable it when running under`dbmem.go`.
		(workspace.NextStartAt.Time.IsZero() \|\|
DanielleMaywood marked this conversation as resolved. Show resolvedHide resolved
		!now.Before(workspace.NextStartAt.Time)) {
		workspaces = append(workspaces, database.GetWorkspacesEligibleForTransitionRow{
		ID: workspace.ID,
		Name: workspace.Name,
Expand All		@@ -6962,7 +7012,7 @@ func (q *FakeQuerier) GetWorkspacesEligibleForTransition(ctx context.Context, no

		if !workspace.DormantAt.Valid &&
		template.TimeTilDormant > 0 &&
		now.Sub(workspace.LastUsedAt) > time.Duration(template.TimeTilDormant) {
		now.Sub(workspace.LastUsedAt) >= time.Duration(template.TimeTilDormant) {
		workspaces = append(workspaces, database.GetWorkspacesEligibleForTransitionRow{
		ID: workspace.ID,
		Name: workspace.Name,
Expand DownExpand Up		@@ -7927,6 +7977,7 @@ func (q *FakeQuerier) InsertWorkspace(_ context.Context, arg database.InsertWork
		Ttl: arg.Ttl,
		LastUsedAt: arg.LastUsedAt,
		AutomaticUpdates: arg.AutomaticUpdates,
		NextStartAt: arg.NextStartAt,
		}
		q.workspaces = append(q.workspaces, workspace)
		return workspace, nil
Expand DownExpand Up		@@ -9868,6 +9919,7 @@ func (q *FakeQuerier) UpdateWorkspaceAutostart(_ context.Context, arg database.U
		continue
		}
		workspace.AutostartSchedule = arg.AutostartSchedule
		workspace.NextStartAt = arg.NextStartAt
		q.workspaces[index] = workspace
		return nil
		}
Expand DownExpand Up		@@ -10017,6 +10069,29 @@ func (q *FakeQuerier) UpdateWorkspaceLastUsedAt(_ context.Context, arg database.
		return sql.ErrNoRows
		}

		func (q *FakeQuerier) UpdateWorkspaceNextStartAt(_ context.Context, arg database.UpdateWorkspaceNextStartAtParams) error {
		err := validateDatabaseType(arg)
		if err != nil {
		return err
		}

		q.mutex.Lock()
		defer q.mutex.Unlock()

		for index, workspace := range q.workspaces {
		if workspace.ID != arg.ID {
		continue
		}

		workspace.NextStartAt = arg.NextStartAt
		q.workspaces[index] = workspace

		return nil
		}

		return sql.ErrNoRows
		}

		func (q *FakeQuerier) UpdateWorkspaceProxy(_ context.Context, arg database.UpdateWorkspaceProxyParams) (database.WorkspaceProxy, error) {
		q.mutex.Lock()
		defer q.mutex.Unlock()
Expand Down