- Notifications
You must be signed in to change notification settings - Fork1.2k
fix: make GetWorkspacesEligibleForTransition return even less false positives#15594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
36 commits Select commitHold shift + click to select a range
78d9bef fix: begin impl of reducing autostart false-positive rate
DanielleMaywooddea0c20 chore: update dbmem.go
DanielleMaywoodd0f1851 fix: dbmem.go impl
DanielleMaywood077439c test: refactor test slightly
DanielleMaywood3b41985 fix: update golden files
DanielleMaywood1a66a14 fix: dbmem.go convertToWorkspaceRowsNoLock
DanielleMaywood9725ec7 fix: pass currentTick to GetWorkspacesEligibleForTransition
DanielleMaywood5e9b806 revert: query change
DanielleMaywoodb2a037b fix: ensure times are converted back to UTC
DanielleMaywood997c902 Merge branch 'main' into dm-experiment-autostart
DanielleMaywooddd05558 test: next start at is only a valid value
DanielleMaywood8bddfdf fix: appease linter
DanielleMaywood66a01a3 chore: add an index for next_start_at
DanielleMaywoodb7434c0 fix: run 'make gen'
DanielleMaywood100f54c chore: begin impl of tests
DanielleMaywoodd201025 Merge branch 'main' into dm-experiment-autostart
DanielleMaywoodeac63b7 test: fix tests
DanielleMaywood1b31cbb fix: use american english
DanielleMaywoodeaf32ee fix: make NextAllowedAutostart look up to 7 days into the future
DanielleMaywood1599b2a fix: TestExecutorAutostartBlocked test
DanielleMaywood142e335 fix: make enterprise template schedule store use quartz.clock
DanielleMaywood3f17e46 fix: infinite loop
DanielleMaywoode993643 refactor: give template schedule store a quartz.clock
DanielleMaywoodd349c56 fix: ensure tests give template schedule store a clock
DanielleMaywooda48fb99 fix: nullify next_start_at on schedule update
DanielleMaywoodcc93075 fix: tests
DanielleMaywood45350d1 chore: remove clock from test
DanielleMaywoodc1648ae Merge branch 'main' into dm-experiment-autostart
DanielleMaywood03d0b7f chore: relocate test
DanielleMaywood23b2ec9 chore: nits
DanielleMaywood18f3c8a Merge branch 'main' into dm-experiment-autostart
DanielleMaywood8b1b6d9 chore: bump migration number
DanielleMaywood2d239a6 fix: stop query returning dormant workspaces
DanielleMaywood2e2f13a Merge branch 'main' into dm-experiment-autostart
DanielleMaywooddf74e6f Merge branch 'main' into dm-experiment-autostart
DanielleMaywooddec3d6c chore: add index to template_id on workspaces
DanielleMaywoodFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Merge branch 'main' into dm-experiment-autostart
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitd201025a175e4aa7e407a9156641f3a976b6477c
There are no files selected for viewing
This merge commit was added into this branch cleanly.
There are no new changes to show, but you can stillview the diff.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.