Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: fix windows postgres tests#15593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugodutka merged 10 commits intomainfromhugodutka/fix-pg-windows-tests
Nov 20, 2024
Merged

Conversation

hugodutka
Copy link
Contributor

@hugodutkahugodutka commentedNov 19, 2024•
edited
Loading

Patches tests that caused Windows Postgres CI in#15520 to consistently fail.

I tested this by temporarily adding Postgres Windows CI to this PR. However, I reverted those changes to merge them with#15520. For reference, here'sa passing CI run from an earlier commit.

Note: Although Windows tests now pass, they remain quite flaky. I recommend running Postgres Windows CI to gather data on these flakes, but I don’t think it should be a required job just yet.

@hugodutkahugodutkaforce-pushed thehugodutka/fix-pg-windows-tests branch from7925384 toa5304dcCompareNovember 20, 2024 10:59
@hugodutkahugodutka marked this pull request as ready for reviewNovember 20, 2024 11:16
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm fine with it being non-required, but it needs to become required before we remove in-memory tests IMO

@hugodutka
Copy link
ContributorAuthor

it needs to become required before we remove in-memory tests

@deansheather that's for sure.

@hugodutkahugodutka merged commit6ed7692 intomainNov 20, 2024
27 checks passed
@hugodutkahugodutka deleted the hugodutka/fix-pg-windows-tests branchNovember 20, 2024 12:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@hugodutkahugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugodutka@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp