Nov 28, 2024 · Nov 19, 2024 · Nov 19, 2024 · Nov 20, 2024 · Nov 21, 2024 · Nov 21, 2024
diff --git a/site/src/api/api.ts b/site/src/api/api.ts

 /**
 * @param organization Can be the organization's ID or name
 * @param tags to filter provisioner daemons by.
 */
 getProvisionerDaemonsByOrganization = async (
 organization: string,
 tags?: Record<string, string>
 ): Promise<TypesGen.ProvisionerDaemon[]> => {
 const params = new URLSearchParams();

 if (tags) {
 params.append('tags', encodeURIComponent(JSON.stringify(tags)));
 }

 const response = await this.axios.get<TypesGen.ProvisionerDaemon[]>(
 `/api/v2/organizations/${organization}/provisionerdaemons`,
 `/api/v2/organizations/${organization}/provisionerdaemons?${params.toString()}`
 );
 return response.data;
 };
diff --git a/site/src/modules/provisioners/useCompatibleProvisioners.ts b/site/src/modules/provisioners/useCompatibleProvisioners.ts
 import { API } from "api/api";
 import { ProvisionerDaemon } from "api/typesGenerated";
 import { useEffect, useState } from "react";

 export const useCompatibleProvisioners = (organization: string | undefined, tags: Record<string, string> | undefined) => {
 const [compatibleProvisioners, setCompatibleProvisioners] = useState<ProvisionerDaemon[]>([])

 useEffect(() => {
 (async () => {
 if (!organization) {
 setCompatibleProvisioners([])
 return
 }

 try {
 const provisioners = await API.getProvisionerDaemonsByOrganization(
 organization,
 tags,
 );

 setCompatibleProvisioners(provisioners);
 } catch (error) {
 setCompatibleProvisioners([])
 }
 })();
 }, [organization, tags])

 return compatibleProvisioners
 }
diff --git a/site/src/pages/CreateTemplatePage/BuildLogsDrawer.tsx b/site/src/pages/CreateTemplatePage/BuildLogsDrawer.tsx
 import { WorkspaceBuildLogs } from "modules/workspaces/WorkspaceBuildLogs/WorkspaceBuildLogs";
 import { type FC, useLayoutEffect, useRef } from "react";
 import { navHeight } from "theme/constants";
 import { useCompatibleProvisioners } from "modules/provisioners/useCompatibleProvisioners";

 type BuildLogsDrawerProps = {
 error: unknown;
 variablesSectionRef,
 ...drawerProps
 }) => {
 const compatibleProvisioners = useCompatibleProvisioners(
 templateVersion?.organization_id,
 templateVersion?.job.tags
 );
 const compatibleProvisionersUnhealthy = compatibleProvisioners.reduce((allUnhealthy, provisioner) => {
 if (!allUnhealthy) {
 // If we've found one healthy provisioner, then we don't need to look at the rest
 return allUnhealthy;
 }
 // Otherwise, all provisioners so far have been unhealthy, so we check the next one

 // If a provisioner has no last_seen_at value, then it's considered unhealthy
 if (!provisioner.last_seen_at) {
 return allUnhealthy;
 }

 // If a provisioner has not been seen within the last 60 seconds, then it's considered unhealthy
 const lastSeen = new Date(provisioner.last_seen_at);
 const oneMinuteAgo = new Date(Date.now() - 60000);
 const unhealthy = lastSeen < oneMinuteAgo;


 return allUnhealthy && unhealthy;
 }, true);

 const logs = useWatchVersionLogs(templateVersion);
 const logsContainer = useRef<HTMLDivElement>(null);

 </IconButton>
 </header>

 { !compatibleProvisioners && !logs ? (
 // If there are no compatible provisioners, warn that this job may be stuck
 <>No compatible provisioners</>
 ) : compatibleProvisionersUnhealthy && !logs ? (
 // If there are compatible provisioners in the db, but they have not reported recent health checks,
 // warn that the job might be stuck
 <>Compatible provisioners are potentially unhealthy. Your job might be delayed</>
 ) : (
 // If there are compatible provisioners and at least one was recently seen, no warning is necessary.
 <></>
 )}

 {isMissingVariables ? (
 <MissingVariablesBanner
 onFillVariables={() => {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -682,12 +682,20 @@ class ApiMethods {

		/**
		* @param organization Can be the organization's ID or name
		* @param tags to filter provisioner daemons by.
		*/
		getProvisionerDaemonsByOrganization = async (
		organization: string,
		tags?: Record<string, string>
		): Promise<TypesGen.ProvisionerDaemon[]> => {
		const params = new URLSearchParams();

		if (tags) {
		params.append('tags', encodeURIComponent(JSON.stringify(tags)));
SasSwart marked this conversation as resolved. Show resolvedHide resolved
		}

		const response = await this.axios.get<TypesGen.ProvisionerDaemon[]>(
		`/api/v2/organizations/${organization}/provisionerdaemons`,
		`/api/v2/organizations/${organization}/provisionerdaemons?${params.toString()}`
		);
		return response.data;
		};
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,29 @@
		import { API } from "api/api";
		import { ProvisionerDaemon } from "api/typesGenerated";
		import { useEffect, useState } from "react";

		export const useCompatibleProvisioners = (organization: string \| undefined, tags: Record<string, string> \| undefined) => {
		const [compatibleProvisioners, setCompatibleProvisioners] = useState<ProvisionerDaemon[]>([])

		useEffect(() => {
		(async () => {
		if (!organization) {
		setCompatibleProvisioners([])
		return
		}

		try {
		const provisioners = await API.getProvisionerDaemonsByOrganization(
		organization,
		tags,
		);

		setCompatibleProvisioners(provisioners);
		} catch (error) {
		setCompatibleProvisioners([])
		}
		})();
		}, [organization, tags])

		return compatibleProvisioners
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -12,6 +12,7 @@ import { useWatchVersionLogs } from "modules/templates/useWatchVersionLogs";
		import { WorkspaceBuildLogs } from "modules/workspaces/WorkspaceBuildLogs/WorkspaceBuildLogs";
		import { type FC, useLayoutEffect, useRef } from "react";
		import { navHeight } from "theme/constants";
		import { useCompatibleProvisioners } from "modules/provisioners/useCompatibleProvisioners";

		type BuildLogsDrawerProps = {
		error: unknown;
Expand All		@@ -27,6 +28,31 @@ export const BuildLogsDrawer: FC<BuildLogsDrawerProps> = ({
		variablesSectionRef,
		...drawerProps
		}) => {
		const compatibleProvisioners = useCompatibleProvisioners(
		templateVersion?.organization_id,
		templateVersion?.job.tags
		);
		const compatibleProvisionersUnhealthy = compatibleProvisioners.reduce((allUnhealthy, provisioner) => {
		if (!allUnhealthy) {
		// If we've found one healthy provisioner, then we don't need to look at the rest
		return allUnhealthy;
		}
		// Otherwise, all provisioners so far have been unhealthy, so we check the next one

		// If a provisioner has no last_seen_at value, then it's considered unhealthy
		if (!provisioner.last_seen_at) {
		return allUnhealthy;
		}

		// If a provisioner has not been seen within the last 60 seconds, then it's considered unhealthy
		const lastSeen = new Date(provisioner.last_seen_at);
		const oneMinuteAgo = new Date(Date.now() - 60000);
		const unhealthy = lastSeen < oneMinuteAgo;


		return allUnhealthy && unhealthy;
		}, true);

		const logs = useWatchVersionLogs(templateVersion);
		const logsContainer = useRef<HTMLDivElement>(null);

Expand DownExpand Up		@@ -65,6 +91,18 @@ export const BuildLogsDrawer: FC<BuildLogsDrawerProps> = ({
		</IconButton>
		</header>

		{ !compatibleProvisioners && !logs ? (
		// If there are no compatible provisioners, warn that this job may be stuck
		<>No compatible provisioners</>
		) : compatibleProvisionersUnhealthy && !logs ? (
		// If there are compatible provisioners in the db, but they have not reported recent health checks,
		// warn that the job might be stuck
		<>Compatible provisioners are potentially unhealthy. Your job might be delayed</>
		) : (
		// If there are compatible provisioners and at least one was recently seen, no warning is necessary.
		<></>
		)}

		{isMissingVariables ? (
		<MissingVariablesBanner
		onFillVariables={() => {
Expand Down