- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(tailnet): add alias with username and short alias to DNS#15585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
spikecurtis commentedNov 19, 2024
| case<-f.ctx.Done(): | ||
| f.t.Error("timed out waiting to send close call") | ||
| returnf.ctx.Err() | ||
| returntimeoutOnFakeErr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note: changes like this are because callingt.Error() after the test case finishes (and context expires int.Cleanup) will panic and create a bunch of extra tests to fail. So, we don't fail the test in these handlers, and instead pass a distinctive error.
ethanndicksonNov 19, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice! I assume it's a similar fix forcoder/internal#217 too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, plus there was a real product bug in that one.
85c3c4c intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Adds DNS aliases of the form
<agent>.<workspace>.<username>.coder.and<workspace>.coder.