Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(cli): use option source name for deprecation warnings#15581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 2 commits intomainfromethan/cli-deprecation-warnings
Nov 19, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedNov 19, 2024•
edited
Loading

Closes#15568.

This improves the deprecation warnings, so that they use the config name for however they were supplied for both the deprecated option, and the recommended options.

(I'm assuming it's relatively obvious for users this is an env variable)

$ set -x CODER_ADDRESS 127.0.0.1:3003$ coder serverWARN: `CODER_ADDRESS` is deprecated, please use `CODER_HTTP_ADDRESS` and `CODER_TLS_ADDRESS` instead.
$ coder server --address 127.0.0.1:3003WARN: `--address` is deprecated, please use `--http-address` and `--tls-address` instead.

YAML names are fully qualified, to make it clear they're set via YAML

$ coder server --config config.yamlWARN: `introspection.logging.verbose` is deprecated, please use `introspection.logging.filter` instead.

This PR also applies the middleware toall commands.

DanielleMaywood reacted with hooray emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewNovember 19, 2024 03:17
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for picking this up@ethanndickson!

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work!

@ethanndicksonethanndicksonforce-pushed theethan/cli-deprecation-warnings branch from74836c8 to3f74426CompareNovember 19, 2024 10:04
@ethanndicksonethanndicksonenabled auto-merge (squash)November 19, 2024 10:05
@ethanndicksonethanndickson merged commit1c08580 intomainNov 19, 2024
27 checks passed
@ethanndicksonethanndickson deleted the ethan/cli-deprecation-warnings branchNovember 19, 2024 10:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhelpful warning is displayed when using deprecated configs
2 participants
@ethanndickson@dannykopping
[8]ページ先頭
©2009-2025 Movatter.jp