NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

fix(site): show error on template upload failure#15558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethanndickson merged 1 commit intomainfromethan/template-upload-fail

Nov 22, 2024

Merged

fix(site): show error on template upload failure#15558

ethanndickson merged 1 commit intomainfromethan/template-upload-fail

Nov 22, 2024

Conversation

Copy link

Member

ethanndickson commentedNov 18, 2024•
edited
Loading

Closes#15441.

Copy link

MemberAuthor

ethanndickson commentedNov 18, 2024

fix(site): show error on template upload failure #15558 👈(View in Graphite)
main

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

github-actionsbot assignedethanndickson

Nov 18, 2024

ethanndickson marked this pull request as ready for review

November 18, 2024 10:51

ethanndickson commented

Nov 18, 2024

View reviewed changes

site/src/pages/CreateTemplatePage/UploadTemplateView.tsx

		onUpload: async (file: File) => {
		try {
		await uploadFileMutation.mutateAsync(file);
		} catch (error) {

Copy link

MemberAuthor

ethanndicksonNov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not familiar with this query library, but what I found is that even though you can setonError, an exception returned frommutateAsync isn't caught unless you explicitly catch it. So, If I displayed the error as part ofonError inuseMutation, I'd still need to wrapmutateAsync in a try block, with an empty catch, which seems pointless.