- Notifications
You must be signed in to change notification settings - Fork928
chore: add standard test logger ignoring db canceled#15556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm a fan of this overall approach of extracting commonly-used test apparatus intotestutil
. I think your refactor missed some imports intailnet/test/integration
but I'm happy to approve once those are fixed and tests are passing.
6391f65
to5ed8bb2
CompareUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I only have that one comment regardingprovisioner/terraform/install.go
but that's not blocking.
5ed8bb2
tof186d26
Compare5861e51
intomainUh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Uh oh!
There was an error while loading.Please reload this page.
Refactors our use of
slogtest
to instantiate a "standard logger" across most of our tests. This standard logger incorporatescoder/slog#217 to also ignore database query canceled errors by default, which are a source of low-severity flakes.Any test that has set non-default
slogtest.Options
is left alone. In particular,coderdtest
defaults to ignoring all errors. We might consider revisiting that decision now that we have better tools to target the really common flaky Error logs on shutdown.