Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add standard test logger ignoring db canceled#15556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/std-test-logger
Nov 18, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedNov 18, 2024
edited
Loading

Refactors our use ofslogtest to instantiate a "standard logger" across most of our tests. This standard logger incorporatescoder/slog#217 to also ignore database query canceled errors by default, which are a source of low-severity flakes.

Any test that has set non-defaultslogtest.Options is left alone. In particular,coderdtest defaults to ignoring all errors. We might consider revisiting that decision now that we have better tools to target the really common flaky Error logs on shutdown.

Emyrk reacted with thumbs up emoji
@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewNovember 18, 2024 08:05
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm a fan of this overall approach of extracting commonly-used test apparatus intotestutil. I think your refactor missed some imports intailnet/test/integration but I'm happy to approve once those are fixed and tests are passing.

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I only have that one comment regardingprovisioner/terraform/install.go but that's not blocking.

@spikecurtisspikecurtis merged commit5861e51 intomainNov 18, 2024
26 of 27 checks passed
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

  • Nov 18, 5:09 AM EST: A user merged this pull request withGraphite.

@spikecurtisspikecurtis deleted the spike/std-test-logger branchNovember 18, 2024 10:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@EmyrkEmyrkAwaiting requested review from Emyrk

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp