Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix listening flake on TestTailnet_ForcesWebSockets#15555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/flake-forces-websockets
Nov 18, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedNov 18, 2024
edited
Loading

Fixes a test flake on TestTailnet_ForcesWebsockets like:

    t.go:106: 2024-11-18 07:44:25.939 [debu]  w2: dial tcp  addr_port="[fd7a:115c:a1e0:46cc:bd8e:400d:1bc6:f6ac]:35565"    t.go:106: 2024-11-18 07:44:25.943 [debu]  w1.net.netstack: netstack: could not connect to local server at 127.0.0.1:35565 (or [::1]:35565)%!(EXTRA *net.OpError=dial tcp [::1]:35565: connect: connection refused)    conn_test.go:146:        Error Trace:/Users/spike/repos/coder/tailnet/conn_test.go:146        Error:      Received unexpected error:                    connect tcp [fd7a:115c:a1e0:46cc:bd8e:400d:1bc6:f6ac]:35565: connection was refused        Test:       TestTailnet/ForcesWebSockets    t.go:106: 2024-11-18 07:44:25.945 [info]  w1: closing tailnet Conn    t.go:106: 2024-11-18 07:44:25.945 [debu]  w1: closing configMaps configLoop    t.go:106: 2024-11-18 07:44:25.945 [debu]  w1: closing nodeUpdater updateLoop    t.go:106: 2024-11-18 07:44:25.945 [debu]  w1: closed netstack    conn_test.go:135:        Error Trace:/Users/spike/repos/coder/tailnet/conn_test.go:135                    /Users/spike/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.8.darwin-arm64/src/runtime/asm_arm64.s:1222        Error:      Received unexpected error:                    connection closed:                        github.com/coder/coder/v2/tailnet.init                            <autogenerated>:1        Test:       TestTailnet/ForcesWebSocketspanic: runtime error: invalid memory address or nil pointer dereference[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1039771dc]goroutine 2224 [running]:github.com/coder/coder/v2/tailnet_test.TestTailnet.func3.2()/Users/spike/repos/coder/tailnet/conn_test.go:136 +0x7ccreated by github.com/coder/coder/v2/tailnet_test.TestTailnet.func3 in goroutine 109/Users/spike/repos/coder/tailnet/conn_test.go:133 +0x7dc

Test didn't synchronize listening on the port before dialing it.

It also has a nil pointer deference when the test fails, which causes a bunch of unrelated output. Also fixed.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewNovember 18, 2024 07:59
@spikecurtisspikecurtisforce-pushed thespike/flake-forces-websockets branch from6cbb82a to98c35a9CompareNovember 18, 2024 08:00
@spikecurtisspikecurtis merged commit1aaaad9 intomainNov 18, 2024
27 checks passed
@spikecurtisspikecurtis deleted the spike/flake-forces-websockets branchNovember 18, 2024 12:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@spikecurtisspikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp