Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(examples/templates/gcp-linux): add GCP region, code-server and JetBrains Gateway modules#15550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
phorcys420 merged 3 commits intomainfromphorcys/promote-modules-gcp-linux
Nov 28, 2024

Conversation

phorcys420
Copy link
Member

@phorcys420phorcys420 commentedNov 16, 2024•
edited
Loading

This PR adds the GCP region, code-server and JetBrains Gateway modules.

  • Testing
    • Workspace gets provisioned and region selector works
    • code-server works as intended
    • JetBrains gateway works as intended

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelNov 24, 2024
@phorcys420
Copy link
MemberAuthor

Works as intended, had to set a default region for theplan step to not fail.
Available on dogfood @https://dev.coder.com/templates/coder/gcp-linux/versions/promote-modules-pr-1053

@phorcys420phorcys420 marked this pull request as ready for reviewNovember 27, 2024 00:09
@phorcys420phorcys420 changed the titlefeat(examples/templates/gcp-linux): promote modulesfeat(examples/templates/gcp-linux): add GCP region, code-server and JetBrains Gateway modulesNov 27, 2024
@phorcys420phorcys420enabled auto-merge (squash)November 27, 2024 00:10
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelNov 28, 2024
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you.

@phorcys420phorcys420 merged commit946328f intomainNov 28, 2024
27 checks passed
@phorcys420phorcys420 deleted the phorcys/promote-modules-gcp-linux branchNovember 28, 2024 05:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifalimatifali approved these changes

@johnstcnjohnstcnAwaiting requested review from johnstcn

Assignees

@phorcys420phorcys420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@phorcys420@matifali
[8]ページ先頭
©2009-2025 Movatter.jp