Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: add error that provisionerkeys require the externalprovisioners feature#15541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 5 commits intomainfromlilac/provisionerkeys-error
Nov 15, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedNov 15, 2024•
edited
Loading

it currently requires the multiple organizations feature, which doesn't make for a good error message. it's a bit misleading and confusing, and would be better gated by the external provisioners feature.

I'm not actuallyadding an error, I'm changing an existing one, but our title bot refuses to let me name the pr accurately 🙃

@aslilacaslilac changed the titlefix: warn that acquiring a provisionerkey requires the external provisioners featurefix: warn that provisionerkeys require the external provisioners feature rather than multiple organizationsNov 15, 2024
@aslilacaslilac changed the titlefix: warn that provisionerkeys require the external provisioners feature rather than multiple organizationsfix: require external provisioners feature for provisionerkeysNov 15, 2024
@aslilacaslilac changed the titlefix: require external provisioners feature for provisionerkeysfix: add warning when acquiring a provisionerkey without the external provisioners featureNov 15, 2024
@aslilacaslilac changed the titlefix: add warning when acquiring a provisionerkey without the external provisioners featurefix: add error that provisionerkeys require the externalprovisioners featureNov 15, 2024
@aslilacaslilac merged commit968c52b intomainNov 15, 2024
25 checks passed
@aslilacaslilac deleted the lilac/provisionerkeys-error branchNovember 15, 2024 21:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@f0sself0sselAwaiting requested review from f0ssel

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp