Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(agent): start rpty lifecycle after all reads/writes#15535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/reconnectingpty-screen-data-race-redux
Nov 15, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedNov 15, 2024•
edited
Loading

Fixescoder/internal#214

#15475 missed that we also write torpty after startingrpty.lifecycle().
This PR moves the function call right at the end. Hopefully this should address the data races before we go resorting to mutexes.

Copy link
Member

@mafredrimafredri left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh I was actually wondering about this but didn't check deeper since the race test didn't catch it.How did you catch it? (Oops, should've read the description.)

@johnstcn
Copy link
MemberAuthor

Oh I was actually wondering about this but didn't check deeper since the race test didn't catch it.How did you catch it? (Oops, should've read the description.)

That other race test didn't win the race! 😆

@johnstcnjohnstcnenabled auto-merge (squash)November 15, 2024 14:43
@johnstcnjohnstcn merged commit12a9d63 intomainNov 15, 2024
33 checks passed
@johnstcnjohnstcn deleted the cj/reconnectingpty-screen-data-race-redux branchNovember 15, 2024 14:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mafredrimafredrimafredri approved these changes

@hugodutkahugodutkaAwaiting requested review from hugodutka

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: (data race) scaletest/Test_Runner/ExpectTimeout/Timeout
2 participants
@johnstcn@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp