- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: add support for WorkspaceUpdates to WebsocketDialer#15534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
spikecurtis commentedNov 15, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
ethanndickson approved these changesNov 18, 2024
40fd326 to615f316Compared0f1a9a to89b90c2Compare615f316 to16992eeCompare89b90c2 to6b3a466Compare6b3a466 tofe7eb34Compare747f7ce intomain 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
spikecurtis commentedNov 18, 2024
Merge activity
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
closes#14730
Adds support for WorkspaceUpdates to the WebsocketDialer. This allows us to dial the new endpoint added in#14847 and connect it up to a
tailnet.Controllersto connect to all agents over the tailnet.I refactored the fakeWorkspaceUpdatesProvider to a mock and moved it to
tailnettestso it could be more easily reused. The Mock is a little more full-featured.