Addsmake/coder-dylib to build the Coder Desktop.dylib for bothamd64 andarm64.
Adds abuild-dylib CI job that builds the dylibs on a macOS runner, signs them, uploads them and the header file as a build artifact, and then downloads them and inserts them into the fat binary build during the regularbuild CI job (which uses an ubuntu runner).
Makes the dylibs and the accompanying header file available for download from/bin on a Coder deployment.
Adds abuild-dylib torelease.yaml.release now downloads and embeds these dylibs in it's builds.
Minor fixes to get release dry-runs working again.

$ codesign -dvv coder-vpn-darwin-amd64.dylib[...]Identifier=com.coder.vpnAuthority=Developer ID Application: Coder Technologies Inc (4399GN35BJ)

/bin:

coder-darwin-amd64coder-darwin-arm64coder-vpn-darwin-amd64.dylibcoder-vpn-darwin-arm64.dylibcoder-vpn-darwin-dylib.hcoder-linux-amd64coder-linux-arm64coder-linux-armv7coder-windows-amd64.execoder-windows-arm64.exe

Latest passingci run:https://github.com/coder/coder/actions/runs/11885370889/
build-dylib artifact:https://github.com/coder/coder/actions/runs/11885370889/artifacts/2199477618
Fullbuild artifact:https://github.com/coder/coder/actions/runs/11885370889/artifacts/2199489548

Latest passingrelease dry-run:https://github.com/coder/coder/actions/runs/11885373782
release build artifact:https://github.com/coder/coder/actions/runs/11885373782/artifacts/2199494843

The C interface for the dylib is currently just:
int OpenTunnel(cReadFD int, cWriteFD int)

github-actionsbot assignedethanndickson

Nov 14, 2024

Copy link

MemberAuthor

ethanndickson commentedNov 14, 2024•
edited
Loading

chore: support building Coder Desktop.dylib #15512 👈(View in Graphite)
main

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

ethanndickson force-pushed theethan/build-dylib branch fromde5c638 to3fc4ec2Compare

November 14, 2024 11:47

Copy link

Member

deansheather commentedNov 15, 2024

Can we call the artifactscodervpn-darwin-arch.ext instead?

Copy link

MemberAuthor

ethanndickson commentedNov 15, 2024•
edited
Loading

Yeah the naming is kinda tricky, how doescoder-{desktop|vpn}-darwin-arch.ext sound? We have a bunch of code for embedding the binaries (hashing, tarring) that relies on the files starting withcoder-, and I don't really want to touch that needlessly.

Also, thedarwin part is kinda implicit, given that we're only exporting a dylib. I guess if we ever added a linux .so, it might use a different header file?

deansheather reviewed

Nov 15, 2024

View reviewed changes

.github/workflows/ci.yamlShow resolvedHide resolved

vpn/dylib/lib.goShow resolvedHide resolved

vpn/dylib/lib.go OutdatedShow resolvedHide resolved

scripts/sign_darwin.shShow resolvedHide resolved

scripts/build_go.sh OutdatedShow resolvedHide resolved

scripts/build_go.shShow resolvedHide resolved

Makefile OutdatedShow resolvedHide resolved

Copy link

Member

deansheather commentedNov 15, 2024

We have a bunch of code for embedding the binaries (hashing, tarring) that relies on the files starting withcoder-

Yeah OK that sounds good to me then.

Also, the darwin part is kinda implicit, given that we're only exporting a dylib

I'd rather keep the standard anyways. The windows binaries can easily be told apart too because of the.exe but we don't dropwindows from the name.