Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat!: allow disabling notifications#15509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 24 commits intomainfromdm-fix-defaults-notifications
Nov 19, 2024
Merged
Changes from1 commit
Commits
Show all changes
24 commits
Select commitHold shift + click to select a range
5c36c93
fix: remove defaults for CODER_EMAIL_ options
DanielleMaywoodNov 12, 2024
196f538
fix: failing tests
DanielleMaywoodNov 12, 2024
b670009
fix: tests (again)
DanielleMaywoodNov 12, 2024
19398cc
fix: run 'make gen'
DanielleMaywoodNov 12, 2024
4175bc8
fix: consistency
DanielleMaywoodNov 13, 2024
66d1a69
nit: trim smarthost
DanielleMaywoodNov 13, 2024
4689e5b
nit: re-add default for CODER_EMAIL_HELLO
DanielleMaywoodNov 13, 2024
01d4957
fix: run 'make {update-golden-files,gen}'
DanielleMaywoodNov 13, 2024
27fa5bf
fix: run 'make fmt'
DanielleMaywoodNov 13, 2024
6ca7844
feat: allow disabling notifications entirely
DanielleMaywoodNov 13, 2024
fb54e45
Merge branch 'main' into dm-fix-defaults-notifications
DanielleMaywoodNov 14, 2024
d5aff28
chore: re-add default for smarthost
DanielleMaywoodNov 14, 2024
01cb999
fix: remove default for deprecated option
DanielleMaywoodNov 14, 2024
c513113
chore: revert change
DanielleMaywoodNov 14, 2024
a8b5a61
chore: remove unrelated test changes
DanielleMaywoodNov 14, 2024
1711e68
revert: more changes
DanielleMaywoodNov 14, 2024
2e03ed1
chore: simplify description
DanielleMaywoodNov 14, 2024
28ec1b7
Merge branch 'main' into dm-fix-defaults-notifications
DanielleMaywoodNov 14, 2024
7ba3a6c
chore: make {gen,update-golden-files}
DanielleMaywoodNov 14, 2024
4a72e4f
chore: rename cfg to notificationsCfg
DanielleMaywoodNov 14, 2024
9c02842
chore: drop enabled flag
DanielleMaywoodNov 18, 2024
dd527f9
fix: invalid test
DanielleMaywoodNov 18, 2024
77d1803
chore: improve info message and add to docs
DanielleMaywoodNov 19, 2024
5fd03b3
test: notifications.Enabled()
DanielleMaywoodNov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
fix: invalid test
  • Loading branch information
@DanielleMaywood
DanielleMaywood committedNov 18, 2024
commitdd527f9ad1ce83e957696578ad53d3d1044b8d07
2 changes: 1 addition & 1 deletioncoderd/notifications/dispatch/smtp_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -440,7 +440,7 @@ func TestSMTP(t *testing.T) {

var hp serpent.HostPort
require.NoError(t, hp.Set(listen.Addr().String()))
tc.cfg.Smarthost =hp
tc.cfg.Smarthost =serpent.String(hp.String())

handler := dispatch.NewSMTPHandler(tc.cfg, logger.Named("smtp"))

Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp