- Notifications
You must be signed in to change notification settings - Fork1.1k
feat!: allow disabling notifications#15509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
24 commits Select commitHold shift + click to select a range
5c36c93 fix: remove defaults for CODER_EMAIL_ options
DanielleMaywood196f538 fix: failing tests
DanielleMaywoodb670009 fix: tests (again)
DanielleMaywood19398cc fix: run 'make gen'
DanielleMaywood4175bc8 fix: consistency
DanielleMaywood66d1a69 nit: trim smarthost
DanielleMaywood4689e5b nit: re-add default for CODER_EMAIL_HELLO
DanielleMaywood01d4957 fix: run 'make {update-golden-files,gen}'
DanielleMaywood27fa5bf fix: run 'make fmt'
DanielleMaywood6ca7844 feat: allow disabling notifications entirely
DanielleMaywoodfb54e45 Merge branch 'main' into dm-fix-defaults-notifications
DanielleMaywoodd5aff28 chore: re-add default for smarthost
DanielleMaywood01cb999 fix: remove default for deprecated option
DanielleMaywoodc513113 chore: revert change
DanielleMaywooda8b5a61 chore: remove unrelated test changes
DanielleMaywood1711e68 revert: more changes
DanielleMaywood2e03ed1 chore: simplify description
DanielleMaywood28ec1b7 Merge branch 'main' into dm-fix-defaults-notifications
DanielleMaywood7ba3a6c chore: make {gen,update-golden-files}
DanielleMaywood4a72e4f chore: rename cfg to notificationsCfg
DanielleMaywood9c02842 chore: drop enabled flag
DanielleMaywooddd527f9 fix: invalid test
DanielleMaywood77d1803 chore: improve info message and add to docs
DanielleMaywood5fd03b3 test: notifications.Enabled()
DanielleMaywoodFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Merge branch 'main' into dm-fix-defaults-notifications
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit28ec1b77a85903c89786e8ebb54efefe1e14a917
There are no files selected for viewing
This merge commit was added into this branch cleanly.
There are no new changes to show, but you can stillview the diff.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.