- Notifications
You must be signed in to change notification settings - Fork923
feat: set DNS hostnames in workspace updates controller#15507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
spikecurtis commentedNov 14, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
This was referencedNov 14, 2024
002e484 toe1ce08dCompare22526ba to2803ed7Compareethanndickson approved these changesNov 14, 2024
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
e1ce08d to08216aaCompare2803ed7 to700a82fCompare700a82f to0d7aa15Compare0d7aa15 to1a3816cCompare916df4d intomain 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
re:#14730
Adds support for the workspace updates protocol controller to also program DNS names for each agent.
Right now, we only program names like
myagent.myworkspace.me.coderandmyworkspace.coder.(if there is exactly one agent in the workspace). We also want to supportmyagent.myworkspace.username.coder., but for that we need to update WorkspaceUpdates RPC to also send the workspace owner's username, which will be in a separate PR.