- Notifications
You must be signed in to change notification settings - Fork913
fix: remove built-in image for Docker template#15504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
matifali left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We opted for theDockerfile over the image to demonstrate that it's possible with Coder to build images on the fly without needing a registry.
But I agree that using a built image is a better practice.
I am ok to switch to a more universal kitchen sink image, only concern is that it will make the first boot slower for new users due to image size. |
Gotcha. i am going to merge this for now, and when we make a better image in |
d3eb896 intomainUh oh!
There was an error while loading.Please reload this page.
-#15504 broke CI on main because ofthe aforementioned issue, this also fixes the test failure.
The hardcoded image is an anti-pattern, leading to weird errors if the
dockergroup is absent. We should either provide a better error in-product or just have a better image.@matifali - also down to use a Devcontainers universal image instead or make this a parameter. Let me know what you think the best "default install" is