- Notifications
You must be signed in to change notification settings - Fork923
feat(provisioner): add support for workspace_owner_login_type#15499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(provisioner): add support for workspace_owner_login_type#15499
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| @@ -703,13 +705,57 @@ func TestProvision(t *testing.T) { | |||
| }}, | |||
| }, | |||
| }, | |||
| { | |||
| Name: "workspace-owner-login-type", | |||
| SkipReason: "field will be added in provider version 1.1.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note: I'm getting the ducks in a row now so that when the provider is released we can lock this in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: I wonder if we could expand this to be more strictly version-dependent?
For example, the tests could have a defined version under which they work and if that version does not exist then the test can be skipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That would be wonderful to have!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, a couple non-blocking nits
Uh oh!
There was an error while loading.Please reload this page.
| @@ -703,13 +705,57 @@ func TestProvision(t *testing.T) { | |||
| }}, | |||
| }, | |||
| }, | |||
| { | |||
| Name: "workspace-owner-login-type", | |||
| SkipReason: "field will be added in provider version 1.1.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: I wonder if we could expand this to be more strictly version-dependent?
For example, the tests could have a defined version under which they work and if that version does not exist then the test can be skipped.
Uh oh!
There was an error while loading.Please reload this page.
4a6b28f intomainUh oh!
There was an error while loading.Please reload this page.
Part ofcoder/terraform-provider-coder#235
Adds support for the
coder_workspace_owner.login_typeattribute.(Note: need to cherry-pickcoder/terraform-provider-coder#287 and do a release)