- Notifications
You must be signed in to change notification settings - Fork1.1k
ci: reenable link checker & fix broken links#15489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ethanndickson commentedNov 13, 2024
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
docs/admin/users/idp-sync.md Outdated
| Next configure the Coder server to read groups from the claim name with the | ||
| [OIDC organization field](../../reference/cli/server.md#--oidc-organization-field) | ||
| server flag: | ||
| OIDC organization field server flag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This CLI arg got moved to runtime config a few days ago, so it's no longer in the reference. The docs will need updating soon.
2777501 to4fd8bb0Compare| -docs | ||
| excludedDirs: | ||
| # Downstream bug in linkspector means large markdown files fail to parse | ||
| # but these are autogenerated and shouldn't need checking |
ethanndicksonNov 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
See failed CI run:https://github.com/coder/coder/actions/runs/11797850940/job/32862729001?pr=15482
https://github.com/micromark/micromark/blob/dd1bbe0c80fe4c4d1e3ee7adeaff1d8e81e3818f/packages/micromark-util-subtokenize/dev/lib/splice-buffer.js#L121-L123
https://stackoverflow.com/questions/22123769/rangeerror-maximum-call-stack-size-exceeded-why
4fd8bb0 to4ae52edCompare| reporter:github-pr-review | ||
| config_file:".github/.linkspector.yml" | ||
| fail_on_error:"true" | ||
| filter_mode:"nofilter" |
ethanndicksonNov 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I incorrectly assumed that the weekly-docs job being started from the cron job would mean it wouldn't use the pull request changes filter, but evidently not. This means it checks the wholedocs folder for the cron job & on PRs. It complained about the emacs link on this PR, even though it wasn't included in the diff, so I'm more confident that it works properly now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So on schedule, we check the whole repo?
What does thefilter_mode mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The default filter_mode was just the PR diff. Now it should be everything mentioned in the.linkspector.yml config.
fa69d1c intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Follow-up on#15484.