- Notifications
You must be signed in to change notification settings - Fork918
fix(cli): add backwards compat for old telemetry env and tests#15476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 7 commits intomainfrommafredri/fix-cli-add-backcompat-for-telemetry-and-testsNov 13, 2024
Merged
fix(cli): add backwards compat for old telemetry env and tests#15476
mafredri merged 7 commits intomainfrommafredri/fix-cli-add-backcompat-for-telemetry-and-testsNov 13, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
d23ad21 toe4eaf58Comparef3fa0ba to1ebcb3bComparedannykopping approved these changesNov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
| // Set the default telemetry to true (normally disabled in tests). | ||
| t.Setenv("CODER_TEST_TELEMETRY_DEFAULT_ENABLE", "true") | ||
| //nolint:paralleltest // No need to reinitialise the variable tt (Go version). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: we should fix our linter.
Suggested change
| //nolint:paralleltest // No need to reinitialise the variable tt (Go version). | |
| //nolint:paralleltest // No need to reinitialise the variable tt (as of go v1.22). |
johnstcn approved these changesNov 13, 2024
e55e8ee intomain 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This was referencedNov 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a backwards compatible
CODER_TELEMETRYenv, currently this is calledCODER_TELEMETRY_ENABLE.Depends oncoder/serpent#23
Fixescoder/internal#209
Refs#15467