Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

examples/docker-local: add explanatory comment#1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/docker-local-doc
May 18, 2022

Conversation

johnstcn
Copy link
Member

Adds a comment to thedocker-local example template regardingcoder.url and pointing users to edit the URL to their environment.

@johnstcnjohnstcn self-assigned thisMay 18, 2022
Copy link
Member

@bpmctbpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wish there was a way we could programmatically detect this, but this makes sense and I imagine it'd work in most cases. 👍🏼

The sucky thing about running docker-compose locally is the docker example is the only one that works.

kylecarbs reacted with thumbs up emoji
@johnstcnjohnstcn merged commit13571b0 intomainMay 18, 2022
@johnstcnjohnstcn deleted the cj/docker-local-doc branchMay 18, 2022 16:10
@coadler
Copy link
Contributor

coadler commentedMay 18, 2022•
edited
Loading

cc@johnstcn@bpmct Can we have a docker-compose specific template?docker-local used to work just fine withoutcoderd being run in docker-compose and this sort of broke my workflow, and seems like an odd default.

@johnstcn
Copy link
MemberAuthor

@coadler we could instead set the access URL of coder tohttps://host.docker.internal:7080 indocker-compose.yaml as per my original proposed change (e699ba1)

@coadler
Copy link
Contributor

@coadler we could instead set the access URL of coder tohttps://host.docker.internal:7080 indocker-compose.yaml as per my original proposed change (e699ba1)

I think that seems reasonable too!

@bpmct
Copy link
Member

@coadler we could instead set the access URL of coder tohttps://host.docker.internal:7080 in docker-compose.yaml as per my original proposed change (e699ba1)

I agree we should do this instead.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@bpmctbpmctbpmct approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@johnstcn@coadler@bpmct@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp