- Notifications
You must be signed in to change notification settings - Fork924
fix: set content type when uploading edited template#15440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
sreya approved these changesNov 8, 2024
8935e21 to19fad93Compared2e4969 intomain 28 checks passed
Uh oh!
There was an error while loading.Please reload this page.
stirby pushed a commit that referenced this pull requestDec 11, 2024
Fixes a bug where a file produced by `generateVersionFiles` (as usedwhen uploading a web UI edited template) produced a file where the`type` field was unset.This meant the change in#15410 used the unset type value as the contentheader when uploading, causing it to always fail.(cherry picked from commitd2e4969)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes a bug where a file produced by
generateVersionFiles(as used when uploading a web UI edited template) produced a file where thetypefield was unset.This meant the change in#15410 used the unset type value as the content header when uploading, causing it to always fail.