- Notifications
You must be signed in to change notification settings - Fork914
chore: improve PR deployments#15430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
matifali commentedNov 7, 2024
- create a GitHub user for the GitHub actor
- Correct user creation command with proper formatting.- Update Slack notification condition for deployment actions.
- Correct user creation command with proper formatting.- Update Slack notification condition for deployment actions.
github-actionsbot commentedNov 7, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Change kube config file permission to 600 for better security and reorderthe template and workspace creation steps to after user promotion.
5a180ec tob5d6efeCompare- Correct user creation command with proper formatting.- Update user role promotion to use `organization-admin`.
b5d6efe to92c06b2Compare- Use public email if available for user creation, else default.- Ensure `GH_TOKEN` is set for the workflow.- Move tmate debug session to trigger only on failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main or release branch
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
329e086 intomain 27 of 29 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.