Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add logging for Run failures in workspacetraffic#15425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/workspacetraffic-log
Nov 7, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedNov 7, 2024•
edited
Loading

Run logs are currently dropped on the floor when workspacetraffic tests fail.

e.g.https://github.com/coder/coder/runs/32640144785

This prints the logs when we get a failure, like

    run_test.go:341:         Error Trace:/Users/spike/repos/coder/scaletest/workspacetraffic/run_test.go:341                    /Users/spike/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.8.darwin-arm64/src/runtime/asm_arm64.s:1222        Error:      Received unexpected error:                    badness:                        github.com/coder/coder/v2/scaletest/workspacetraffic.(*Runner).Run                            /Users/spike/repos/coder/scaletest/workspacetraffic/run.go:174        Test:       TestRun/App        Messages:   RUN LOGS:                    2024-11-07 13:04:30.274 [debu]  config  agent_id=00000000-0000-0000-0000-000000000000  reconnecting_pty_id=95bb480f-cd26-4633-8332-328d44ffa997  height=25  width=80  tick_interval=1s  bytes_per_tick=1024                    2024-11-07 13:04:30.274 [debu]  connect to workspace agent  agent_id=00000000-0000-0000-0000-000000000000                    2024-11-07 13:04:30.274 [info]  sending traffic to workspace app  agent_id=00000000-0000-0000-0000-000000000000  app=echo                    2024-11-07 13:04:30.276 [debu]  reading from agent  agent_id=00000000-0000-0000-0000-000000000000                    2024-11-07 13:04:30.276 [debu]  writing to agent  agent_id=00000000-0000-0000-0000-000000000000                    2024-11-07 13:04:31.526 [debu]  done reading from agent  agent_id=00000000-0000-0000-0000-000000000000                    2024-11-07 13:04:32.276 [debu]  done writing to agent  agent_id=00000000-0000-0000-0000-000000000000                                        END RUN LOGS

So, hopefully we can diagnose flakes.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewNovember 7, 2024 13:09
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!:shipit:

@spikecurtisspikecurtis merged commitba483ef intomainNov 7, 2024
34 checks passed
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

  • Nov 7, 8:16 AM EST: A user merged this pull request withGraphite.

@spikecurtisspikecurtis deleted the spike/workspacetraffic-log branchNovember 7, 2024 13:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp