Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Read params from file for template/workspace creation#1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AbhineetJain merged 13 commits intomainfrom1377-feat-load-parameters-from-file
May 20, 2022
Merged
Changes from1 commit
Commits
Show all changes
13 commits
Select commitHold shift + click to select a range
b35b7b3
Read params from file for template/workspace creation
AbhineetJainMay 18, 2022
e69ae31
Use os.ReadFile
AbhineetJainMay 18, 2022
dc80543
Refactor reading params into a separate module
AbhineetJainMay 19, 2022
931e7d5
Add comments and unit tests
AbhineetJainMay 20, 2022
0e6b2d4
Fix merge conflicts and refactor
AbhineetJainMay 20, 2022
8a075f4
Rename variable
AbhineetJainMay 20, 2022
71e94e3
Uncomment and fix unit test
AbhineetJainMay 20, 2022
d27d202
Fix comment
AbhineetJainMay 20, 2022
692b975
Refactor tests
AbhineetJainMay 20, 2022
1a12be1
Fix unit tests for windows
AbhineetJainMay 20, 2022
1491620
Fix unit tests for Windows
AbhineetJainMay 20, 2022
74989ac
Add comments for the hotfix
AbhineetJainMay 20, 2022
e584e81
Merge branch 'main' into 1377-feat-load-parameters-from-file
AbhineetJainMay 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Uncomment and fix unit test
  • Loading branch information
@AbhineetJain
AbhineetJain committedMay 20, 2022
commit71e94e31f15451acece3ed3c0b300a93958b5c2d
88 changes: 44 additions & 44 deletionscli/create_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -252,48 +252,48 @@ func TestCreate(t *testing.T) {
}
<-doneChan
})
//t.Run("WithParameterFileNotContainingTheValue", func(t *testing.T) {
//t.Parallel()
//client := coderdtest.New(t,nil)
//user := coderdtest.CreateFirstUser(t, client)
// coderdtest.NewProvisionerDaemon(t, client)
//version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, &echo.Responses{
//Parse: []*proto.Parse_Response{{
//Type: &proto.Parse_Response_Complete{
//Complete: &proto.Parse_Complete{
//ParameterSchemas: []*proto.ParameterSchema{{
//AllowOverrideSource: true,
//Name: "region",
//Description: "description",
//DefaultSource: &proto.ParameterSource{
//Scheme: proto.ParameterSource_DATA,
//Value: "something",
//},
//DefaultDestination: &proto.ParameterDestination{
//Scheme: proto.ParameterDestination_PROVISIONER_VARIABLE,
//},
//}},
//},
//},
//}},
//Provision: echo.ProvisionComplete,
//ProvisionDryRun: echo.ProvisionComplete,
//})
//coderdtest.AwaitTemplateVersionJob(t, client, version.ID)
//template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
//parameterFile, _ := os.CreateTemp(t.TempDir(), "testParameterFile*.yaml")
//_, _ = parameterFile.WriteString("zone: \"bananas\"")
//cmd, root := clitest.New(t, "create", "my-workspace", "--template", template.Name, "--parameter-file", parameterFile.Name())
//clitest.SetupConfig(t, client, root)
//doneChan := make(chan struct{})
//pty := ptytest.New(t)
//cmd.SetIn(pty.Input())
//cmd.SetOut(pty.Output())
//go func() {
//defer close(doneChan)
//err := cmd.Execute()
//require.EqualError(t, err, "Parameter value absent in parameter file for \"region\"!")
//}()
//<-doneChan
//})
t.Run("WithParameterFileNotContainingTheValue", func(t *testing.T) {
t.Parallel()
client := coderdtest.New(t,&coderdtest.Options{IncludeProvisionerD: true})
user := coderdtest.CreateFirstUser(t, client)

version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, &echo.Responses{
Parse: []*proto.Parse_Response{{
Type: &proto.Parse_Response_Complete{
Complete: &proto.Parse_Complete{
ParameterSchemas: []*proto.ParameterSchema{{
AllowOverrideSource: true,
Name: "region",
Description: "description",
DefaultSource: &proto.ParameterSource{
Scheme: proto.ParameterSource_DATA,
Value: "something",
},
DefaultDestination: &proto.ParameterDestination{
Scheme: proto.ParameterDestination_PROVISIONER_VARIABLE,
},
}},
},
},
}},
Provision: echo.ProvisionComplete,
ProvisionDryRun: echo.ProvisionComplete,
})
coderdtest.AwaitTemplateVersionJob(t, client, version.ID)
template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
parameterFile, _ := os.CreateTemp(t.TempDir(), "testParameterFile*.yaml")
_, _ = parameterFile.WriteString("zone: \"bananas\"")
cmd, root := clitest.New(t, "create", "my-workspace", "--template", template.Name, "--parameter-file", parameterFile.Name())
clitest.SetupConfig(t, client, root)
doneChan := make(chan struct{})
pty := ptytest.New(t)
cmd.SetIn(pty.Input())
cmd.SetOut(pty.Output())
go func() {
defer close(doneChan)
err := cmd.Execute()
require.EqualError(t, err, "Parameter value absent in parameter file for \"region\"!")
}()
<-doneChan
})
}
[8]ページ先頭
©2009-2025 Movatter.jp