- Notifications
You must be signed in to change notification settings - Fork925
feat: add support for multiple tunnel destinations in tailnet#15409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedNov 6, 2024
ContributorAuthor
spikecurtis commentedNov 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This was referencedNov 6, 2024
cb664c3 to8993828Compared3a937d to2bc1218Compare8993828 toed2ba52Compare2bc1218 toa82e73aCompareethanndickson approved these changesNov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like these tests, easy to follow.
LGTM 👏
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ed2ba52 tod9b0988Comparea82e73a to5fe6c15Compared9b0988 tob8062abCompare5fe6c15 to28d24aaCompareb8062ab to845efd2Compare28d24aa to173a166Compareb8ed4ea to2603e6dCompare173a166 to5b58b35Compare2603e6d to778457bCompare5b58b35 tof318880Comparef318880 toce65647Compare778457b to8c00ebcComparece65647 to44fd538Comparee5661c2 intomain 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#14729
Expands the Coordination controller used by the CLI client to allow multiple tunnel destinations (agents). Our current client uses just one, but this unifies the logic so that when we add Coder VPN, 1 is just a special case of "many."