- Notifications
You must be signed in to change notification settings - Fork925
chore: refactor ServerTailnet to use tailnet.Controllers#15408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
spikecurtis commentedNov 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This was referencedNov 6, 2024
c6c3f05
toe3f80df
Comparecb664c3
to8993828
Comparee3f80df
to791e183
Compare8993828
toed2ba52
Compareethanndickson approved these changesNov 7, 2024
791e183
toc79d83d
Compareed2ba52
tod9b0988
Comparec79d83d
toe6e3c8f
Compared9b0988
tob8062ab
Comparebf47e04
toabd4edd
Compareb8062ab
to845efd2
Compare845efd2
tob8ed4ea
Compareabd4edd
to718722a
Compareb8ed4ea
to2603e6d
Compare2603e6d
to778457b
Compare8c00ebc
intomain 29 of 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
chore of#14729
Refactors the
ServerTailnet
to usetailnet.Controller
so that we reuse logic around reconnection and handling control messages, instead of reimplementing. This unifies our "client" use of the tailscale API across CLI, coderd, and wsproxy.