- Notifications
You must be signed in to change notification settings - Fork928
fix: use NoLock dbmem subqueries forGetWorkspaceAgentScriptTimingsByBuildID
#15405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main or release branch
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
2c24dd6
toe2e8d74
CompareTestWorkspaceBuildTimings
GetWorkspaceAgentScriptTimingsByBuildID
e2e8d74
toba8e8cd
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
f0a4de5
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Closescoder/internal#202.
Addresses the problem mentioned in the issue, and also makes sure subtests don't reuse
testing.T
from the main test.