Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: allow workspace owners to view timings#15364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 1 commit intomainfromstevenmasley/api_timings
Nov 5, 2024

Conversation

Emyrk
Copy link
Member

Anyone with authz access to a workspace should be able to read timings information of its builds.

To do this withoutAsSystemContext would do an extra 4 db calls.

Closes#15250

Anyone with authz access to a workspace should be able to readtimings information of its builds.
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Were we running into an issue fetching the agents before?

@johnstcn
Copy link
Member

Createdcoder/internal#194 for the test flake

@Emyrk
Copy link
MemberAuthor

Were we running into an issue fetching the agents before?

I am unsure? I was solving the timing issue linked in the PR description

@EmyrkEmyrk merged commit8024c1d intomainNov 5, 2024
27 checks passed
@EmyrkEmyrk deleted the stevenmasley/api_timings branchNovember 5, 2024 02:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with workspace builds timing RBAC
2 participants
@Emyrk@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp