Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add resume token controller#15346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/14729-resume-token-controller
Nov 7, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedNov 4, 2024•
edited
Loading

Implements a controller for the Tailnet API resume token RPC, by refactoring fromworkspacesdk.

chore re:#14729

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedNov 4, 2024•
edited
Loading

Copy link
Collaborator

@sreyasreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. I'm not generally a fan of bidirectional dependencies (a type with a field that has a reference to the type) but I understand why you need it here.

ethanndickson reacted with thumbs up emoji
@spikecurtisspikecurtisforce-pushed thespike/14729-telemetry-controller branch from7cdbc31 to112075dCompareNovember 5, 2024 09:51
@spikecurtisspikecurtisforce-pushed thespike/14729-resume-token-controller branch fromaf61bca to4f79cf7CompareNovember 5, 2024 09:51
@spikecurtisspikecurtisforce-pushed thespike/14729-telemetry-controller branch from112075d to0b51bd5CompareNovember 5, 2024 10:01
@spikecurtisspikecurtisforce-pushed thespike/14729-resume-token-controller branch from4f79cf7 to5552b4fCompareNovember 5, 2024 10:02
@spikecurtisspikecurtisforce-pushed thespike/14729-telemetry-controller branch from0b51bd5 toba7f57cCompareNovember 6, 2024 13:13
@spikecurtisspikecurtisforce-pushed thespike/14729-resume-token-controller branch from5552b4f to2180c3fCompareNovember 6, 2024 13:13
@spikecurtisspikecurtisforce-pushed thespike/14729-telemetry-controller branch 2 times, most recently from865250d to948b0fbCompareNovember 6, 2024 16:05
@spikecurtisspikecurtisforce-pushed thespike/14729-resume-token-controller branch from2180c3f to82852adCompareNovember 6, 2024 16:05
@spikecurtisspikecurtis changed the base branch fromspike/14729-telemetry-controller tographite-base/15346November 6, 2024 16:23
@spikecurtisspikecurtisforce-pushed thespike/14729-resume-token-controller branch from82852ad toe702cb7CompareNovember 6, 2024 16:23
@spikecurtisspikecurtis changed the base branch fromgraphite-base/15346 tomainNovember 6, 2024 16:24
@spikecurtisspikecurtisforce-pushed thespike/14729-resume-token-controller branch frome702cb7 to49baee8CompareNovember 6, 2024 16:24
@spikecurtisspikecurtis merged commitd7e8627 intomainNov 7, 2024
27 checks passed
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

  • Nov 7, 2:32 AM EST: A user merged this pull request withGraphite.

@spikecurtisspikecurtis deleted the spike/14729-resume-token-controller branchNovember 7, 2024 07:32
jaaydenh pushed a commit that referenced this pull requestNov 8, 2024
Implements a controller for the Tailnet API resume token RPC, by refactoring from `workspacesdk`.chore re:#14729
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sreyasreyasreya approved these changes

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@spikecurtis@sreya@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp