Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: refactor coordination#15343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/14729-controllers
Nov 5, 2024
Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedNov 4, 2024•
edited
Loading

Refactors the way clients of the Tailnet API (clients of the API, which include both workspace "agents" and "clients") interact with the API. Introduces the idea of abstract "controllers" for each of the RPCs in the API, and implements a Coordination controller by refactoring fromworkspacesdk.

chore re:#14729

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedNov 4, 2024•
edited
Loading

Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, lgtm!

Copy link
Collaborator

@sreyasreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM although I'm admittedly not super well versed in this code

@spikecurtisspikecurtis merged commit886dcbe intomainNov 5, 2024
37 checks passed
@spikecurtisspikecurtis deleted the spike/14729-controllers branchNovember 5, 2024 09:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

@sreyasreyasreya approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@spikecurtis@sreya@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp