Nov 5, 2024 · Nov 4, 2024 · Nov 4, 2024 · Nov 4, 2024
diff --git a/site/src/modules/templates/useWatchVersionLogs.ts b/site/src/modules/templates/useWatchVersionLogs.ts
 return;
 }

 if (templateVersionStatus !== "running") {
 if (
 templateVersionStatus !== "running" &&
 templateVersionStatus !== "pending"
 ) {
 return;
 }

diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx
 },
 };

 letcalls =0;
 letrunning =false;
 server.use(
 http.get(
 "/api/v2/organizations/:org/templates/:template/versions/:version",
 () => {
 calls += 1;
 return HttpResponse.json(
 calls > 1 ? MockRunningTemplateVersion : MockPendingTemplateVersion,
 running ? MockRunningTemplateVersion : MockPendingTemplateVersion,
 );
 },
 ),
 const status = await screen.findByRole("status");
 expect(status).toHaveTextContent("Pending");

 // Manually update the endpoint, as to not rely on the editor page
 // making a specific number of requests.
 running = true;

 await waitFor(
 () => {
 expect(status).toHaveTextContent("Running");
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,7 +20,10 @@ export const useWatchVersionLogs = (
		return;
		}

		if (templateVersionStatus !== "running") {
		if (
		templateVersionStatus !== "running" &&
		templateVersionStatus !== "pending"
		) {
		return;
		}

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -324,14 +324,13 @@ test("display pending badge and update it to running when status changes", async
		},
		};

		letcalls =0;
		letrunning =false;
		server.use(
		http.get(
		"/api/v2/organizations/:org/templates/:template/versions/:version",
		() => {
		calls += 1;
		return HttpResponse.json(
		calls > 1 ? MockRunningTemplateVersion : MockPendingTemplateVersion,
		running ? MockRunningTemplateVersion : MockPendingTemplateVersion,
Copy link MemberAuthor ethanndicksonNov 4, 2024• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This test was failing because as we end up querying`versions/{id}` an extra time with this change. I think we should just manually update the status instead of relying on a specific number of api calls. BrunoQuaresma reacted with thumbs up emoji Copy link Collaborator BrunoQuaresmaNov 4, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Can you please leave a comment in the code about why we are using`running`? I can see my self not remembering this in two months. ethanndickson reacted with thumbs up emoji
		);
		},
		),
Expand All		@@ -348,6 +347,10 @@ test("display pending badge and update it to running when status changes", async
		const status = await screen.findByRole("status");
		expect(status).toHaveTextContent("Pending");

		// Manually update the endpoint, as to not rely on the editor page
		// making a specific number of requests.
		running = true;

		await waitFor(
		() => {
		expect(status).toHaveTextContent("Running");
Expand Down