Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(site): watch build logs while job is pending or running#15341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/insta-fail-logs-fix
Nov 5, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedNov 4, 2024•
edited
Loading

Closes#15292.

Currently, if the frontend never sees a build job enter 'running', it'll never end up watching the logs. If we start watching the logs earlier we're able to catch cases where the job goespending ->failed, such as when the build fails immediately.

matifali reacted with hooray emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndicksonforce-pushed theethan/insta-fail-logs-fix branch 3 times, most recently from8910f3b to37f1016CompareNovember 4, 2024 04:14
calls+=1;
returnHttpResponse.json(
calls>1 ?MockRunningTemplateVersion :MockPendingTemplateVersion,
running ?MockRunningTemplateVersion :MockPendingTemplateVersion,
Copy link
MemberAuthor

@ethanndicksonethanndicksonNov 4, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This test was failing because as we end up queryingversions/{id} an extra time with this change. I think we should just manually update the status instead of relying on a specific number of api calls.

BrunoQuaresma reacted with thumbs up emoji
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you please leave a comment in the code about why we are usingrunning? I can see my self not remembering this in two months.

ethanndickson reacted with thumbs up emoji
@ethanndicksonethanndickson marked this pull request as ready for reviewNovember 4, 2024 04:15
@ethanndicksonethanndickson changed the titlefix: watch build logs while job is pending or runningfix(site): watch build logs while job is pending or runningNov 4, 2024
@ethanndicksonethanndickson merged commit8b5a18c intomainNov 5, 2024
29 checks passed
@ethanndicksonethanndickson deleted the ethan/insta-fail-logs-fix branchNovember 5, 2024 14:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Web UI hangs on template plan failure

2 participants

@ethanndickson@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp