- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: include if direct connection is over private network in ping diagnostics#15313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
ethanndickson commentedNov 1, 2024
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
8772013 to3f99c57CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main or release branch
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
3f99c57 to336628bComparematifali commentedNov 12, 2024
@ethanndickson Is it supposed to auto merge? |
ethanndickson commentedNov 12, 2024
Oops, forgot about this |
6117f46 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Whilst the
networking-troubleshootingdocs page already mentions that a direct connection can be established over a private network, even if there are no STUN servers, it's worth this is the case at the end of the ping output.This also removes a print statement that was dirtying up the diagnostic output, and corrects the name of the
--disable-direct-connectionsflag.