The string format is able to be changed to extract more value. I recognize this is not perfect, but I wrote it trying to learn more about these locks. It felt valuable enough to keep. Not all values are handled correctly here, I'll add functionality as required.

Some example output

Open a TX in modeserializable and runGetQuotaConsumedForUser()

794-<nil> [granted] <nil>/virtualxid/ExclusiveLock: waiting to acquire virtual tx id lock793-<nil> [granted] <nil>/virtualxid/ExclusiveLock: waiting to acquire virtual tx id lock794-<nil> [granted] pg_locks/relation/AccessShareLock: 793-<nil> [granted] workspace_builds/relation/AccessShareLock: 793-<nil> [granted] workspace_builds/tuple/SIReadLock: page=0 tuple=1793-<nil> [granted] workspace_builds_job_id_key/relation/AccessShareLock: 793-<nil> [granted] workspace_builds_pkey/relation/AccessShareLock: 793-<nil> [granted] workspace_builds_workspace_id_build_number_key/page/SIReadLock: page=1793-<nil> [granted] workspace_builds_workspace_id_build_number_key/relation/AccessShareLock: 793-<nil> [granted] workspaces/relation/AccessShareLock: 793-<nil> [granted] workspaces/relation/SIReadLock: 793-<nil> [granted] workspaces_owner_id_lower_idx/relation/AccessShareLock: 793-<nil> [granted] workspaces_owner_id_lower_idx/page/SIReadLock: page=1793-<nil> [granted] workspaces_pkey/relation/AccessShareLock:

RunUpdateWorkspaceBuildCostByID in the TX

868-<nil> [granted] <nil>/virtualxid/ExclusiveLock: waiting to acquire virtual tx id lock867- 3689 [granted] <nil>/transactionid/ExclusiveLock: ???867-<nil> [granted] <nil>/virtualxid/ExclusiveLock: waiting to acquire virtual tx id lock868-<nil> [granted] pg_locks/relation/AccessShareLock: 867-<nil> [granted] workspace_builds/relation/AccessShareLock: 867-<nil> [granted] workspace_builds/relation/RowExclusiveLock: 867-<nil> [granted] workspace_builds_job_id_key/relation/AccessShareLock: 867-<nil> [granted] workspace_builds_job_id_key/relation/RowExclusiveLock: 867-<nil> [granted] workspace_builds_pkey/relation/RowExclusiveLock: 867-<nil> [granted] workspace_builds_pkey/relation/AccessShareLock: 867-<nil> [granted] workspace_builds_pkey/page/SIReadLock: page=1867-<nil> [granted] workspace_builds_workspace_id_build_number_key/relation/RowExclusiveLock: 867-<nil> [granted] workspace_builds_workspace_id_build_number_key/relation/AccessShareLock: 867-<nil> [granted] workspace_builds_workspace_id_build_number_key/page/SIReadLock: page=1867-<nil> [granted] workspaces/relation/AccessShareLock: 867-<nil> [granted] workspaces/relation/SIReadLock: 867-<nil> [granted] workspaces_owner_id_lower_idx/relation/AccessShareLock: 867-<nil> [granted] workspaces_owner_id_lower_idx/page/SIReadLock: page=1867-<nil> [granted] workspaces_pkey/relation/AccessShareLock:

Specifically these are thenew locks aquired:

868-<nil> [granted] <nil>/virtualxid/ExclusiveLock: waiting to acquire virtual tx id lock867- 3689 [granted] <nil>/transactionid/ExclusiveLock: ???868-<nil> [granted] pg_locks/relation/AccessShareLock: 867-<nil> [granted] workspace_builds/relation/RowExclusiveLock: 867-<nil> [granted] workspace_builds_job_id_key/relation/RowExclusiveLock: 867-<nil> [granted] workspace_builds_pkey/relation/RowExclusiveLock: 867-<nil> [granted] workspace_builds_pkey/page/SIReadLock: page=1867-<nil> [granted] workspace_builds_workspace_id_build_number_key/relation/RowExclusiveLock:

Used to respond here:#15261 (comment)

chore: add PGLocks query to analyze what locks are held in pg

6646d04

github-actionsbot assignedEmyrk

Oct 31, 2024

move to pglocks.go file

2f8cf7a

Emyrk marked this pull request as ready for review

October 31, 2024 15:04

Emyrk added4 commits

October 31, 2024 11:08

fmt

6e0c67a

make gen

ed52eb5

linting

0ecdab5

ignore PGLocks

d615075

Emyrk commented

Oct 31, 2024

View reviewed changes

coderd/database/pglocks.go

Comment on lines +50 to +57

		case "relation":
		details = ""
		case "page":
		details = fmt.Sprintf("page=%d", *l.Page)
		case "tuple":
		details = fmt.Sprintf("page=%d tuple=%d", l.Page, l.Tuple)
		case "virtualxid":
		details = "waiting to acquire virtual tx id lock"