Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(site): refactor DAU chart to avoid seat consumption focus#15307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/refactor-dau
Oct 31, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Related tohttps://github.com/coder/coder/issues/15297

  • Clearly display this as Daily Active Users
  • Remove the user limit bar at the top for licensed deployments
  • Explain in the tooltip that this is for measuring user activity and has no connection to license consumption

@BrunoQuaresmaBrunoQuaresma requested review frommatifali,bpmct anda teamOctober 31, 2024 14:54
@BrunoQuaresmaBrunoQuaresma self-assigned thisOct 31, 2024
@BrunoQuaresmaBrunoQuaresma requested review fromcode-asher and removed request fora teamOctober 31, 2024 14:54
Comment on lines 128 to 133
<HelpTooltipText>
When a connection is initiated to a user&apos;s workspace they are
considered an active user. e.g. apps, web terminal, SSH
considered an active user. e.g. apps, web terminal, SSH. This is for
measuring user activity and has no connection to license
consumption.
</HelpTooltipText>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am okay with the new messaging.

BrunoQuaresma reacted with heart emoji
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is great!

Copy link

@cdr-botcdr-botbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@BrunoQuaresmaBrunoQuaresma merged commit4849b4d intomainOct 31, 2024
31 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/refactor-dau branchOctober 31, 2024 15:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 31, 2024
@matifali
Copy link
Member

@stirby, do you want to pick this into the release/2.17 branch?

@stirby
Copy link
Collaborator

Done@matifali.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@stirbystirbystirby left review comments

@matifalimatifalimatifali approved these changes

@cdr-botcdr-bot[bot]cdr-bot[bot] approved these changes

@bpmctbpmctAwaiting requested review from bpmct

@code-ashercode-asherAwaiting requested review from code-ashercode-asher was automatically assigned from coder/ts

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@BrunoQuaresma@matifali@stirby

[8]ページ先頭

©2009-2025 Movatter.jp