Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: workspaces query to correctly user username from users table#15305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 4 commits intomainfromstevenmasley/workspace_owner_name_filter
Oct 31, 2024

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedOct 31, 2024
edited
Loading

Fixes#15302

The subquery on the users table was incorrectly using the username from theworkspaces table, not theusers table.

This passedsqlc-vet because the column did exist in the query, it just was not the correct one.


Note: If we do not care aboutdeleted users, we can drop querying theUsers table at all and use theowner_username on the workspaces. But then we'd get deleted users with the same name 😢

Kira-Pilot reacted with hooray emoji
@EmyrkEmyrk changed the titlechore: add unit test to verify filter by owner namefix: workspaces query to correctly user username from users tableOct 31, 2024
@EmyrkEmyrk marked this pull request as ready for reviewOctober 31, 2024 13:59
@EmyrkEmyrk requested a review fromjohnstcnOctober 31, 2024 13:59
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Stamp 👍

@EmyrkEmyrk merged commit9d03e04 intomainOct 31, 2024
25 checks passed
@EmyrkEmyrk deleted the stevenmasley/workspace_owner_name_filter branchOctober 31, 2024 16:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 31, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail to query workspaces by owner name
2 participants
@Emyrk@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp