Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: tweak e2e test timeouts#15275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 8 commits intomainfromlilac/e2e-timeouts
Oct 30, 2024
Merged

chore: tweak e2e test timeouts#15275

aslilac merged 8 commits intomainfromlilac/e2e-timeouts
Oct 30, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedOct 29, 2024•
edited by matifali
Loading

Closescoder/internal#178

tweak some timeouts for slow tests/operations to be more targeted, so that we can make the generic timeout shorterand reduce the number of flakes caused by timeouts on the long running/slow tests.

@aslilacaslilac requested review froma team andbcpeinhardt and removed request fora teamOctober 29, 2024 20:17
@bcpeinhardt
Copy link
Contributor

Is there a particular reason this is still in Draft? Looks good to me as a short term tweak.

Drive by comment only vaguely related to this PR (non-blocking): I think we should be treating timeouts as first class test criteria as opposed something we tweak to handle flakes. That said, I'm aware the test execution environment makes all the difference.

@aslilacaslilac marked this pull request as ready for reviewOctober 29, 2024 23:59
@aslilac
Copy link
MemberAuthor

because I forgor to hit "ready" lol

bcpeinhardt reacted with laugh emoji

@matifali
Copy link
Member

@aslilacaslilac merged commit85ff8e0 intomainOct 30, 2024
30 checks passed
@aslilacaslilac deleted the lilac/e2e-timeouts branchOctober 30, 2024 16:07
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 30, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bcpeinhardtbcpeinhardtbcpeinhardt approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: test-e2e-premium
3 participants
@aslilac@bcpeinhardt@matifali
[8]ページ先頭
©2009-2025 Movatter.jp