- Notifications
You must be signed in to change notification settings - Fork926
fix: stop activity bump if no tracked sessions#15237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like there are still some tests that need to be updated?
Yup, I'll need to replicate some logic from the ssh command to get the tests passing and should be g2g after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Approved from pairing session. This is a safer option because it leaves the legacy behaviour unchanged.
d83f4eb intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Part of#15176
I originally kept this the same because I wanted to be conservative about when we start dropping activity, but this is proving to be a problem when using
coder sshwith--usage-app=disabled. Because the workspace agent still counts this as a connection (I think it still should so it's counted somewhere) but not as a SSH / IDE session. This leads to background ssh tasks that want to be untracked still continuing to bump activity when it shouldn't. This makes it so we have to have an explicit session to bump activity.