Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(provisioner/terraform): extract terraform parsing logic to package tfparse#15230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 4 commits intomainfromcj/extract-pkg-tfextract
Oct 25, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedOct 25, 2024•
edited
Loading

Related to#15087

This PR extracts the logic for extracting variables and workspace tags to a separate packagetfextracttfparse.

This does not modify any existing logic, but keeps the existing tests in the same location.
A future PR will add more functionality + tests to this package.

@johnstcnjohnstcn changed the titlechore(provisioner/terraform): extract terraform parsing logic to package tfextractchore(provisioner/terraform): extract terraform parsing logic to package tfparseOct 25, 2024
Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me with one stylistic issue

Co-authored-by: Danielle Maywood <danielle@themaywoods.com>
@johnstcnjohnstcn merged commit5ad4747 intomainOct 25, 2024
26 checks passed
@johnstcnjohnstcn deleted the cj/extract-pkg-tfextract branchOctober 25, 2024 13:48
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

@defelmnqdefelmnqAwaiting requested review from defelmnq

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnstcn@mafredri@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp