Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(helm/coder): set serviceAccount.disableCreate=false by default, add tests#15197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 5 commits intomainfromcj/helm-fix-sa-disable-create
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions.github/workflows/ci.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -90,6 +90,7 @@ jobs:
- "coderd/**"
- "enterprise/**"
- "examples/*"
- "helm/**"
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@ethanndickson does that look right to you?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yep

johnstcn reacted with heart emoji
- "provisioner/**"
- "provisionerd/**"
- "provisionersdk/**"
Expand Down
4 changes: 4 additions & 0 deletionshelm/coder/tests/chart_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,10 @@ var testCases = []testCase{
name: "sa_extra_rules",
expectedError: "",
},
{
name: "sa_disabled",
expectedError: "",
},
}

type testCase struct {
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/auto_access_url_1.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +97,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/auto_access_url_2.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +97,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/auto_access_url_3.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +97,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/command.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +97,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/command_args.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +97,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/default_values.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +97,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/env_from.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +97,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/extra_templates.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/extra-templates.yaml
apiVersion: v1
kind: ConfigMap
Expand DownExpand Up@@ -92,7 +106,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/labels_annotations.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +97,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/prometheus.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -84,7 +98,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
15 changes: 14 additions & 1 deletionhelm/coder/tests/testdata/provisionerd_psk.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations: {}
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +97,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
16 changes: 15 additions & 1 deletionhelm/coder/tests/testdata/sa.golden
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,19 @@
---
# Source: coder/templates/coder.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
annotations:
eks.amazonaws.com/role-arn: arn:aws:iam::123456789012:role/coder-service-account
labels:
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: coder
app.kubernetes.io/part-of: coder
app.kubernetes.io/version: 0.1.0
helm.sh/chart: coder-0.1.0
name: coder-service-account
---
# Source: coder/templates/rbac.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand DownExpand Up@@ -83,7 +98,6 @@ spec:
app.kubernetes.io/instance: release-name
---
# Source: coder/templates/coder.yaml
---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down
Loading
Loading
[8]ページ先頭
©2009-2025 Movatter.jp