Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(helm/coder): set serviceAccount.disableCreate=false by default, add tests#15197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 5 commits intomainfromcj/helm-fix-sa-disable-create
Oct 23, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedOct 23, 2024•
edited
Loading

@johnstcnjohnstcn changed the titleCj/helm fix sa disable createfix(helm/coder): set serviceAccount.disableCreate=false by default, add testsOct 23, 2024
@ethanndickson
Copy link
Member

ethanndickson commentedOct 23, 2024•
edited
Loading

While you're here, might be worth addinghelm/** to the go test file check inci.yaml, so the helm tests get run even when only yaml files change.

johnstcn reacted with thumbs up emoji

@johnstcnjohnstcnforce-pushed thecj/helm-fix-sa-disable-create branch from1ae4ce6 to19a429dCompareOctober 23, 2024 16:04
@@ -90,6 +90,7 @@ jobs:
- "coderd/**"
- "enterprise/**"
- "examples/*"
- "helm/**"
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@ethanndickson does that look right to you?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yep

johnstcn reacted with heart emoji
@johnstcnjohnstcn marked this pull request as ready for reviewOctober 23, 2024 16:09
@johnstcnjohnstcn merged commitfed70bd intomainOct 23, 2024
35 checks passed
@johnstcnjohnstcn deleted the cj/helm-fix-sa-disable-create branchOctober 23, 2024 20:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ericpaulsenericpaulsenericpaulsen approved these changes

@sreyasreyaAwaiting requested review from sreya

@ethanndicksonethanndicksonAwaiting requested review from ethanndickson

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@ethanndickson@ericpaulsen
[8]ページ先頭
©2009-2025 Movatter.jp