Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: make helm golden files to fix ci#15196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/helm-golden
Oct 23, 2024
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedOct 23, 2024•
edited
Loading

The go tests that would have checked for the outdated golden files didn't get run as part of#14817 because onlyhelm/** files were modified.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson marked this pull request as ready for reviewOctober 23, 2024 14:50
@ethanndicksonethanndicksonenabled auto-merge (squash)October 23, 2024 14:55
@sreya
Copy link
Collaborator

@ethanndickson I'm a little out of the loop here, is there anything in this PR that prevents this from happening again?

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we also modify the ci to run go tests on changes inhelm/**

@ethanndicksonethanndickson merged commit57386ed intomainOct 23, 2024
34 checks passed
@ethanndicksonethanndickson deleted the ethan/helm-golden branchOctober 23, 2024 15:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 23, 2024
@johnstcn
Copy link
Member

I'm not sure we should be disabling SA creation by default?

@ethanndickson
Copy link
MemberAuthor

Should we also modify the ci to run go tests on changes in helm/**

Yeah, sorry, good idea but I had auto-merge on 😭. Sounds like the original PR might need another look too

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@sreyasreyaAwaiting requested review from sreya

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ethanndickson@sreya@johnstcn@matifali
[8]ページ先頭
©2009-2025 Movatter.jp