Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: show audit logs for forgot password flow#15181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 7 commits intomainfromdm-forgot-password-audit-logs
Oct 22, 2024

Conversation

@DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedOct 22, 2024•
edited
Loading

Fixes#15150

Audit logs for requesting a password reset, and a user updating their password, now show up in the audit log.

Screenshot 2024-10-22 at 12 48 27

@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewOctober 22, 2024 11:11
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work! The only potential quibble I have is the naming -- perhaps "password reset requested" would be more clear?

Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚢 it

@DanielleMaywoodDanielleMaywood merged commit5076161 intomainOct 22, 2024
31 of 33 checks passed
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@DanielleMaywoodDanielleMaywood deleted the dm-forgot-password-audit-logs branchOctober 22, 2024 12:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

+1 more reviewer

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DanielleMaywoodDanielleMaywood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

coderd/audit: ensure audit logs created for user password reset requests

4 participants

@DanielleMaywood@BrunoQuaresma@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp