- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: check unstaged files during ci lint#15120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ethanndickson commentedOct 17, 2024
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
4b3a9a3 to4c34304Compare4c34304 to7b51225CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main or release branch
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
| -name:Check for unstaged files | ||
| run:| | ||
| rm -f ./actionlint ./typos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thetypos action we use doesn't let you modify the binary install directory to anything other than the current directory (Is there a good reason why?)
46cce33 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
golangci-lint runmakes changes to files for trivial lints, such as import ordering, but CI doesn't currently check for these changes like it does forfmtandgen. It might be possible to havegolangci-lintreturn an error when it makes a change, but that would only be for Go, and it seems sensible to have it be language agnostic.There's perhaps an argument to be made (at least in my head) that
lintshouldn't be making changes, only raising warnings/errors, but that's not whatgolangci-linthas decided.