Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: use barrier inTestInflightDispatchesMetric#15107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 1 commit intomainfromfix-flaky-metrics
Oct 16, 2024

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedOct 16, 2024•
edited
Loading

Fixes:coder/internal#109

Spotted in:https://github.com/coder/coder/actions/runs/11363823264/job/31608588543

It seems that notification messages are successfully dispatched before the test runner starts checking if they are in-flight (flaky).

    t.go:99: 2024-10-16 10:33:05.385 [info]  coderd.manager.notifier: started  notifier_id=c502e78d-19a4-45d9-9368-f08da485d5be    t.go:99: 2024-10-16 10:33:05.385 [debu]  coderd.manager.notifier: dequeued messages  notifier_id=c502e78d-19a4-45d9-9368-f08da485d5be  count=2...    t.go:99: 2024-10-16 10:33:05.671 [debu]  coderd.manager.notifier: batch completed  notifier_id=c502e78d-19a4-45d9-9368-f08da485d5be  count=2    t.go:99: 2024-10-16 10:33:05.672 [debu]  coderd.manager.notifier: dequeued messages  notifier_id=c502e78d-19a4-45d9-9368-f08da485d5be  count=0

Fixes:

    metrics_test.go:342:         Error Trace:/home/runner/work/coder/coder/coderd/notifications/metrics_test.go:342        Error:      Condition never satisfied        Test:       TestInflightDispatchesMetric

Resolvescoder/internal#109

@mtojekmtojek self-assigned thisOct 16, 2024
@mtojekmtojek changed the titletest: user barrier inTestInflightDispatchesMetrictest: use barrier inTestInflightDispatchesMetricOct 16, 2024
@mtojekmtojek requested a review fromjohnstcnOctober 16, 2024 11:55
@mtojekmtojek marked this pull request as ready for reviewOctober 16, 2024 11:55
@matifali
Copy link
Member

@mtojek is it same ascoder/internal#109?

@mtojek
Copy link
MemberAuthor

Yes.

matifali reacted with thumbs up emoji

@mtojekmtojek merged commit416d67b intomainOct 16, 2024
39 checks passed
@mtojekmtojek deleted the fix-flaky-metrics branchOctober 16, 2024 12:12
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestInflightDispatchesMetric
3 participants
@mtojek@matifali@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp