Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: ignore slog errors inTestUserLatencyInsights#15105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 1 commit intomainfromfix-flaky-insights
Oct 16, 2024

Conversation

mtojek
Copy link
Member

Spotted in:https://github.com/coder/coder/actions/runs/11362544440/job/31604644424

It looks likeTestUserLatencyInsights failed due to a random error while reporting agent stats:

    t.go:108: 2024-10-16 09:13:08.529 [erro]  workspacestats: failed to load template schedule bumping activity, defaulting to bumping by 60min  request_id=4ca1de78-75d9-44ca-a1d9-73d9aa32ced7  workspace_id=6a1b979a-b432-4f6b-8985-974ee66c7be3  template_id=47d60e91-9e06-4c1f-ad6e-735e02c63cce ...        error= fetch object:                   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).GetTemplateByID.fetch[...].func1                       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:427                 - pq: canceling statement due to user request         *** slogtest: log detected at level ERROR; TEST FAILURE ***

@mtojekmtojek self-assigned thisOct 16, 2024
@mtojekmtojek requested a review fromjohnstcnOctober 16, 2024 11:10
@mtojekmtojek marked this pull request as ready for reviewOctober 16, 2024 11:10
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we useslogtest.IgnoredErrorIs: []error{pq.ErrCanceled} or similar instead?

@mtojek
Copy link
MemberAuthor

I might be wrong, but it seems there isn't anything equivalent topq.ErrCanceled. These are all I found:

// Common error typesvar (ErrNotSupported=errors.New("pq: Unsupported command")ErrInFailedTransaction=errors.New("pq: Could not complete operation in a failed transaction")ErrSSLNotSupported=errors.New("pq: SSL is not enabled on the server")ErrSSLKeyUnknownOwnership=errors.New("pq: Could not get owner information for private key, may not be properly protected")ErrSSLKeyHasWorldPermissions=errors.New("pq: Private key has world access. Permissions should be u=rw,g=r (0640) if owned by root, or u=rw (0600), or less")ErrCouldNotDetectUsername=errors.New("pq: Could not detect default username. Please provide one explicitly")errUnexpectedReady=errors.New("unexpected ReadyForQuery")errNoRowsAffected=errors.New("no RowsAffected available after the empty statement")errNoLastInsertID=errors.New("no LastInsertId available after the empty statement"))

@mtojekmtojek merged commit21feb42 intomainOct 16, 2024
30 checks passed
@mtojekmtojek deleted the fix-flaky-insights branchOctober 16, 2024 11:20
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mtojek@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp